Bug 92466 - [EFL] Fix wrong return value in EWK_VIEW_XXX macro
Summary: [EFL] Fix wrong return value in EWK_VIEW_XXX macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 92507
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-26 23:45 PDT by Gyuyoung Kim
Modified: 2012-07-29 19:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.35 KB, patch)
2012-07-26 23:50 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (8.44 KB, patch)
2012-07-27 00:54 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-07-26 23:45:17 PDT 
There are wrong return values in EWK_VIEW_XXX macros. The wrong return values should be fixed. In addition, API description is also modified according to returned value change.
Comment 1 Gyuyoung Kim 2012-07-26 23:50:39 PDT 
Created attachment 154857 [details]
Patch
Comment 2 Gyuyoung Kim 2012-07-27 00:02:45 PDT 
Comment on attachment 154857 [details]
Patch

Attachment 154857 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13372214
Comment 3 Gyuyoung Kim 2012-07-27 00:54:13 PDT 
Created attachment 154869 [details]
Patch
Comment 4 Gyuyoung Kim 2012-07-27 01:31:40 PDT 
Comment on attachment 154869 [details]
Patch

Thank you for your review.
Comment 5 WebKit Review Bot 2012-07-27 02:55:28 PDT 
Comment on attachment 154869 [details]
Patch

Clearing flags on attachment: 154869

Committed r123858: <http://trac.webkit.org/changeset/123858>
Comment 6 WebKit Review Bot 2012-07-27 02:55:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2012-07-27 07:42:33 PDT 
Comment on attachment 154869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154869&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:4042
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);

This change looks wrong. This breaks the unit tests. By default, the policy is to accept, which means that we need to return true.
Comment 8 Chris Dumez 2012-07-27 08:03:38 PDT 
Comment on attachment 154869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154869&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:4046
> +        return false;

Actually, it is this line in particular that is wrong. The EINA checks can stay keep using false.
Comment 9 Chris Dumez 2012-07-27 08:24:14 PDT 
Gyuyoung, in the future you can run the unit tests using:
Tools/Script/run-efl-tests

You would have caught the problem early.