There is currently no way for the client to get notified whenever cookies are added, modified or removed. We need to provide such functionality in Ewk_Cookie_Manager.
Created attachment 154895 [details] Patch
Comment on attachment 154895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154895&action=review > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:44 > +struct Watch_Changes_Callback_Data { > + Ewk_Cookie_Manager_Changes_Watch_Cb callback; I dont think the Data here is such a good addition given that it is containing an actual callback. Is this stuct even needed. It seems as you can only have one callback with user data > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:66 > + Watch_Changes_Callback_Data changeWatcher; The naming seems a bit weird here given the name of the variable and the name of the struct. A watcher indicates something active
Comment on attachment 154895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154895&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:44 >> + Ewk_Cookie_Manager_Changes_Watch_Cb callback; > > I dont think the Data here is such a good addition given that it is containing an actual callback. Is this stuct even needed. It seems as you can only have one callback with user data I would prefer to keep the struct since this is the approach I have used in order files for callbacks + userData. I think it is more scalable. How about renaming _Data with _Handler then? >> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:66 >> + Watch_Changes_Callback_Data changeWatcher; > > The naming seems a bit weird here given the name of the variable and the name of the struct. A watcher indicates something active You're right. How about changeHandler then?
ok fine
Created attachment 154913 [details] Patch Take Kenneth's feedback into consideration.
Comment on attachment 154913 [details] Patch Clearing flags on attachment: 154913 Committed r123870: <http://trac.webkit.org/changeset/123870>
All reviewed patches have been landed. Closing bug.