Bug 92479 - Add runtime flag to enable/disable JS memory information
Summary: Add runtime flag to enable/disable JS memory information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 90858 92498
  Show dependency treegraph
 
Reported: 2012-07-27 02:51 PDT by Zoltan Horvath
Modified: 2012-07-27 10:19 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (1.32 KB, patch)
2012-07-27 02:53 PDT, Zoltan Horvath
hausmann: review-
hausmann: commit-queue-
Details | Formatted Diff | Diff
proposed patch (3.04 KB, patch)
2012-07-27 05:48 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2012-07-27 02:51:22 PDT
We need console.memory JS object to be accessible for performance tests memory consumption measurements.
Comment 1 Zoltan Horvath 2012-07-27 02:53:34 PDT
Created attachment 154889 [details]
proposed patch
Comment 2 Simon Hausmann 2012-07-27 02:58:39 PDT
Comment on attachment 154889 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review

> Source/WebKit/qt/Api/qwebsettings.cpp:274
> +        settings->setMemoryInfoEnabled(true);

What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness?
Comment 3 Zoltan Horvath 2012-07-27 03:05:57 PDT
(In reply to comment #2)
> (From update of attachment 154889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.cpp:274
> > +        settings->setMemoryInfoEnabled(true);
> 
> What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness?

It will enable WebCore/page/MemoryInfo.h. We should expose it only for DRT/WTR, where is the better place to set this enabled?
Comment 4 Simon Hausmann 2012-07-27 03:13:25 PDT
(In reply to comment #2)
> (From update of attachment 154889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.cpp:274
> > +        settings->setMemoryInfoEnabled(true);
> 
> What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness?

Perhaps InternalSettings.idl?
Comment 5 Simon Hausmann 2012-07-27 05:07:41 PDT
Comment on attachment 154889 [details]
proposed patch

Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :)
Comment 6 Zoltan Horvath 2012-07-27 05:09:19 PDT
(In reply to comment #5)
> (From update of attachment 154889 [details])
> Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :)

Sure, thanks! I will upload the patch soon. :)
Comment 7 Zoltan Horvath 2012-07-27 05:48:08 PDT
Created attachment 154914 [details]
proposed patch
Comment 8 WebKit Review Bot 2012-07-27 10:19:31 PDT
Comment on attachment 154914 [details]
proposed patch

Clearing flags on attachment: 154914

Committed r123881: <http://trac.webkit.org/changeset/123881>
Comment 9 WebKit Review Bot 2012-07-27 10:19:35 PDT
All reviewed patches have been landed.  Closing bug.