Bug 92479 – Add runtime flag to enable/disable JS memory information

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Zoltan Horvath]

We need console.memory JS object to be accessible for performance tests memory consumption measurements.

[Zoltan Horvath]

Created attachment 154889 [details]
proposed patch

[Simon Hausmann]

Comment on attachment 154889 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review

> Source/WebKit/qt/Api/qwebsettings.cpp:274
> +        settings->setMemoryInfoEnabled(true);

What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness?

[Zoltan Horvath]

(In reply to comment #2)
> (From update of attachment 154889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.cpp:274
> > +        settings->setMemoryInfoEnabled(true);
> 
> What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness?

It will enable WebCore/page/MemoryInfo.h. We should expose it only for DRT/WTR, where is the better place to set this enabled?

[Simon Hausmann]

(In reply to comment #2)
> (From update of attachment 154889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.cpp:274
> > +        settings->setMemoryInfoEnabled(true);
> 
> What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness?

Perhaps InternalSettings.idl?

[Simon Hausmann]

Comment on attachment 154889 [details]
proposed patch

Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :)

[Zoltan Horvath]

(In reply to comment #5)
> (From update of attachment 154889 [details])
> Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :)

Sure, thanks! I will upload the patch soon. :)

[Zoltan Horvath]

Created attachment 154914 [details]
proposed patch

[WebKit Review Bot]

Comment on attachment 154914 [details]
proposed patch

Clearing flags on attachment: 154914

Committed r123881: <http://trac.webkit.org/changeset/123881>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.