Bug 92463 – [EFL][WK2] Stop using C API to interact with the page in Ewk_View

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

We currently use the C API to interact with the PageProxy in Ewk_View even though we keep a pointer to the PageProxy object. This means we call toAPI() on our PageProxy object all the time for no reason.

[Chris Dumez]

Created attachment 154855 [details]
Patch

[Simon Hausmann]

Comment on attachment 154855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154855&action=review

I think the patch looks good, apart from the boolean trap below:

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:630
> +    priv->pageClient->page()->reload(true);

This and the other invocation of reload() a few lines up is a classic example of the boolean trap. I suggest to replace it with a comment:

    ->reload(/*bypassCache*/ true);

[Chris Dumez]

Created attachment 154880 [details]
Patch

Take Simon's feedback into consideration.

[Chris Dumez]

Comment on attachment 154880 [details]
Patch

Patch is broken.

[Chris Dumez]

Created attachment 154881 [details]
Patch

[WebKit Review Bot]

Comment on attachment 154881 [details]
Patch

Rejecting attachment 154881 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:


Parsed 2 diffs from patch file(s).
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
Hunk #3 FAILED at 593.
Hunk #7 succeeded at 768 with fuzz 2.
1 out of 17 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Haus..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13373325

[Chris Dumez]

Created attachment 154901 [details]
Patch for landing

Rebase on master. Could someone please cq+ ?

[WebKit Review Bot]

Comment on attachment 154901 [details]
Patch for landing

Clearing flags on attachment: 154901

Committed r123866: <http://trac.webkit.org/changeset/123866>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.