[WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows editing.

[Mikhail Pozdnyakov]

WebPage::handleEditingKeyboardEvent does not check whether the node allows editing.
Affects the behavior of fast/events/key-events-in-input-button.html test.

[Mikhail Pozdnyakov]

Created attachment 154607 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 154607 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154607&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2149
> +    // Don't allow text insertion for nodes that cannot edit.
> +    if (!frame->editor()->canEdit())

You might not always have an editor() either.

[Mikhail Pozdnyakov]

(In reply to comment #2)
> (From update of attachment 154607 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154607&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2149
> > +    // Don't allow text insertion for nodes that cannot edit.
> > +    if (!frame->editor()->canEdit())
> 
> You might not always have an editor() either.

this function ends already with following:
    return frame->editor()->insertText(evt->keyEvent()->text(), evt);

and here is from Frame.h

    inline Editor* Frame::editor() const
    {
        return &m_editor;
    }

[Kenneth Rohde Christiansen]

Ah maybe that changed then

[WebKit Review Bot]

Comment on attachment 154607 [details]
patch

Clearing flags on attachment: 154607

Committed r123732: <http://trac.webkit.org/changeset/123732>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.