Bug 92340 - Add a ChromeClient method to send message traces from WebCore to the client.
Summary: Add a ChromeClient method to send message traces from WebCore to the client.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 92337
Blocks: 92341
  Show dependency tree / graph
 
Reported: 2012-07-25 23:37 PDT by Jer Noble
Modified: 2012-07-26 11:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.52 KB, patch)
2012-07-26 00:01 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (19.25 KB, patch)
2012-07-26 00:08 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (26.93 KB, patch)
2012-07-26 10:19 PDT, Jer Noble 		andersca: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-07-25 23:37:21 PDT 
Add a ChromeClient method to send message traces from WebCore to the client.
Comment 1 Jer Noble 2012-07-26 00:01:30 PDT 
Created attachment 154556 [details]
Patch
Comment 2 Jer Noble 2012-07-26 00:08:45 PDT 
Created attachment 154558 [details]
Patch
Comment 3 Gyuyoung Kim 2012-07-26 00:30:39 PDT 
Comment on attachment 154558 [details]
Patch

Attachment 154558 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13339596
Comment 4 Early Warning System Bot 2012-07-26 00:42:23 PDT 
Comment on attachment 154558 [details]
Patch

Attachment 154558 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13340602
Comment 5 Mark Rowe (bdash) 2012-07-26 01:03:16 PDT 
Comment on attachment 154558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154558&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:779
> +    if (!m_page->corePage()->settings()->messageTracingEnabled())
> +        return;

In your related patch you're always checking this condition before calling the function. Is it really necessary to perform the check again?
Comment 6 Jer Noble 2012-07-26 07:48:07 PDT 
(In reply to comment #5)
> (From update of attachment 154558 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154558&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:779
> > +    if (!m_page->corePage()->settings()->messageTracingEnabled())
> > +        return;
> 
> In your related patch you're always checking this condition before calling the function. Is it really necessary to perform the check again?

I considered that, but wanted to protect against bad future selves who ignore the setting before calling traceMessage().  I'm open to pulling it out, or replacing it with an assert.
Comment 7 Jer Noble 2012-07-26 10:19:08 PDT 
Created attachment 154681 [details]
Patch

Renamed things to refer to "diagnostic logging".
Comment 8 Gyuyoung Kim 2012-07-26 10:26:09 PDT 
Comment on attachment 154681 [details]
Patch

Attachment 154681 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13340848
Comment 9 Early Warning System Bot 2012-07-26 10:29:03 PDT 
Comment on attachment 154681 [details]
Patch

Attachment 154681 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13353827
Comment 10 Jer Noble 2012-07-26 11:46:10 PDT 
Committed r123778: <http://trac.webkit.org/changeset/123778>