Bug 92337 - Add setting to enable and disable message tracing.
Summary: Add setting to enable and disable message tracing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 92340
  Show dependency tree / graph
 
Reported: 2012-07-25 23:23 PDT by Jer Noble
Modified: 2012-07-26 11:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch (11.52 KB, patch)
2012-07-26 00:05 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (11.58 KB, patch)
2012-07-26 08:42 PDT, Jer Noble 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-07-25 23:23:24 PDT 
Add setting to enable and disable message tracing.
Comment 1 Jer Noble 2012-07-26 00:05:27 PDT 
Created attachment 154557 [details]
Patch
Comment 2 Mark Rowe (bdash) 2012-07-26 00:59:23 PDT 
While "message tracing" is a term we use for this, I don't think it's descriptive enough to use within WebKit and WebCore. Something like "diagnostic event recording" would be more descriptive of what it does.
Comment 3 Mark Rowe (bdash) 2012-07-26 01:05:31 PDT 
And given that you're not implementing the relevant ChromeClient methods for WebKit1, why bother adding the preference code at all for it?
Comment 4 Jer Noble 2012-07-26 07:50:39 PDT 
(In reply to comment #3)
> And given that you're not implementing the relevant ChromeClient methods for WebKit1, why bother adding the preference code at all for it?

The WebKit1 support will come in a future patch.   I'm trying to break them up into digestible pieces. :)
Comment 5 Jer Noble 2012-07-26 07:53:51 PDT 
(In reply to comment #2)
> While "message tracing" is a term we use for this, I don't think it's descriptive enough to use within WebKit and WebCore. Something like "diagnostic event recording" would be more descriptive of what it does.

Fair point, but "event" is a pretty overloaded term already in WebCore, whereas "trace/tracing" isn't.  Perhaps "diagnostic tracing"? "Diagnostic logging"?
Comment 6 Jer Noble 2012-07-26 08:42:39 PDT 
Created attachment 154658 [details]
Patch

Renamed everything "diagnostic logging".
Comment 7 Jer Noble 2012-07-26 11:26:54 PDT 
Committed r123775: <http://trac.webkit.org/changeset/123775>