Bug 92282 – Unify JSC date and time formating functions

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Patrick R. Gansterer]

Unify JSC date and time formating functions

[Patrick R. Gansterer]

Created attachment 154421 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 154421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review

> Source/JavaScriptCore/runtime/DateConversion.cpp:-2
>  /*
> - * Copyright (C) 1999-2000 Harri Porten ([e-mail])

This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable.

> Source/JavaScriptCore/runtime/DateConversion.h:-2
>  /*
> - * Copyright (C) 1999-2000 Harri Porten ([e-mail])

Ditto.

[Patrick R. Gansterer]

Created attachment 154578 [details]
Patch (manually edited)

(In reply to comment #2)
> (From update of attachment 154421 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review
> 
> > Source/JavaScriptCore/runtime/DateConversion.cpp:-2
> >  /*
> > - * Copyright (C) 1999-2000 Harri Porten ([e-mail])
> 
> This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable.

I don't think that I'll ever use svn again, since i switched to git.

> > Source/JavaScriptCore/runtime/DateConversion.h:-2
> >  /*
> > - * Copyright (C) 1999-2000 Harri Porten ([e-mail])
> 
> Ditto.

IMHO the header changes should be easy enough to review.

[Ryosuke Niwa]

(In reply to comment #3)
> Created an attachment (id=154578) [details]
> Patch (manually edited)
> 
> (In reply to comment #2)
> > (From update of attachment 154421 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review
> > 
> > > Source/JavaScriptCore/runtime/DateConversion.cpp:-2
> > >  /*
> > > - * Copyright (C) 1999-2000 Harri Porten ([e-mail])
> > 
> > This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable.

Okay. No problem. Please ask someone else to review it.

[Ryosuke Niwa]

By the way, regardless of whether it's hard to review or not, someone needs to fix the patch before landing it since we're adding new files, not moving the file & modifying it. That's a misrepresentation of what's happening here.

[Geoffrey Garen]

Comment on attachment 154578 [details]
Patch (manually edited)

r=me

[Patrick R. Gansterer]

Created attachment 156521 [details]
Patch (manually edited)

There was a problem with years out of the range 0-9999.

[Patrick R. Gansterer]

Created attachment 156522 [details]
Interdiff

Difference between the last patch, since https://bugs.webkit.org/attachment.cgi?oldid=154578&action=interdiff&newid=156521 does not seam to work.

[Geoffrey Garen]

Comment on attachment 156521 [details]
Patch (manually edited)

r=me

[WebKit Review Bot]

Comment on attachment 156521 [details]
Patch (manually edited)

Clearing flags on attachment: 156521

Committed r124817: <http://trac.webkit.org/changeset/124817>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.