Bug 91936 – [WIN] Use GetTimeZoneInformation() for getting the timezone name

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Patrick R. Gansterer]

[WIN] Use GetTimeZoneInformation() for getting the timezone name

[Patrick R. Gansterer]

Created attachment 153686 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 153686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153686&action=review

> Source/JavaScriptCore/runtime/DateConversion.cpp:93
> +    DWORD result = GetTimeZoneInformation(&timeZoneInformation);

I would have named this variable daylightType instead.

> Source/JavaScriptCore/runtime/DateConversion.cpp:94
> +    CString timeZoneNameString = String(result == TIME_ZONE_ID_DAYLIGHT ? timeZoneInformation.DaylightName : timeZoneInformation.StandardName).latin1();

It's unfortunate that we have to convert WCHAR to char here.
I would use ascii().data() instead possibly allocating String as a local variable.

[Ryosuke Niwa]

Comment on attachment 153686 [details]
Patch

Okay, I withdraw my r+. We need to be more careful here. I thought DaylightName could only be 3-letter abbreviations but this apparently isn't the case. It could be a full long timezone name.

[Patrick R. Gansterer]

Created attachment 156901 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 156901 [details]
Patch

This is more like it!

[WebKit Review Bot]

Comment on attachment 156901 [details]
Patch

Clearing flags on attachment: 156901

Committed r125004: <http://trac.webkit.org/changeset/125004>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.