[EFL][WK2] Keyboard events miss key location data.

[Mikhail Pozdnyakov]

EFL WK2 does not initialize WebKeyboardEvent::m_isKeypad field.
This causes failure of fast/events/keydown-numpad-keys.html test.

[Mikhail Pozdnyakov]

Created attachment 154314 [details]
patch

[Chris Dumez]

Comment on attachment 154314 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review

> Source/WebKit2/Shared/efl/WebEventFactory.cpp:47
> +static const char* keyPadPrefix = "KP_";

Please use: static const char keyPadPrefix[] = "KP_";

> Source/WebKit2/Shared/efl/WebEventFactory.cpp:163
> +    const String& keyName = String(event->key);

Why not use simply "String keyName(event->key);" ?

> Source/WebKit2/Shared/efl/WebEventFactory.cpp:180
> +    const String& keyName = String(event->key);

ditto.

[Gyuyoung Kim]

Comment on attachment 154314 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review

> Source/WebKit2/ChangeLog:9
> +        This caused failure of fast/events/keydown-numpad-keys.html test.

Don't you need to unskip this test ?

[Mikhail Pozdnyakov]

(In reply to comment #3)
> (From update of attachment 154314 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        This caused failure of fast/events/keydown-numpad-keys.html test.
> 
> Don't you need to unskip this test ?

It's already unskipped and works well for EFL WK1.

[Mikhail Pozdnyakov]

Created attachment 154323 [details]
patch v2

Thanks for review, Chris!

[Chris Dumez]

Comment on attachment 154323 [details]
patch v2

LGTM. Thanks.

[Gyuyoung Kim]

Comment on attachment 154323 [details]
patch v2

Looks fine.

[WebKit Review Bot]

Comment on attachment 154323 [details]
patch v2

Clearing flags on attachment: 154323

Committed r123860: <http://trac.webkit.org/changeset/123860>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.