Bug 92122 - [NRWT] Rename baseline_search_path() to default_baseline_search_path()
Summary: [NRWT] Rename baseline_search_path() to default_baseline_search_path()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: NRWT
Depends on:
Blocks: 64491 90555
  Show dependency treegraph
 
Reported: 2012-07-24 08:26 PDT by Kristóf Kosztyó
Modified: 2012-07-25 07:00 PDT (History)
4 users (show)

See Also:


Attachments
proposed refactoring (5.19 KB, patch)
2012-07-24 08:29 PDT, Kristóf Kosztyó
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2012-07-24 08:26:40 PDT
The Port's baseline_search_path() method doesn't return the finally search path because of the --additional-platform-directory change the final path. It will be better if we rename it and add a new method which return the final path.
Comment 1 Kristóf Kosztyó 2012-07-24 08:29:18 PDT
Created attachment 154072 [details]
proposed refactoring
Comment 2 Dirk Pranke 2012-07-24 11:08:28 PDT
Comment on attachment 154072 [details]
proposed refactoring

Agreed. Looks good to me. Thanks!
Comment 3 Kristóf Kosztyó 2012-07-25 07:00:51 PDT
Committed r123614: <http://trac.webkit.org/changeset/123614>