Bug 92077 - [EFL][WK2] Fix possible crash in didSendRequestForResource
Summary: [EFL][WK2] Fix possible crash in didSendRequestForResource
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 61838 91345
  Show dependency treegraph
Reported: 2012-07-24 01:11 PDT by Chris Dumez
Modified: 2012-07-24 02:22 PDT (History)
4 users (show)

See Also:

Patch (3.07 KB, patch)
2012-07-24 01:19 PDT, Chris Dumez
kenneth: review+
Details | Formatted Diff | Diff
Patch for landing (3.08 KB, patch)
2012-07-24 01:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-24 01:11:25 PDT
In ewk_view_resource_load_client's didSendRequestForResource(), we need to check that the wkRedirectResponse is not NULL before using it.
The redirect response may indeed may NULL if there was no redirection.
Comment 1 Chris Dumez 2012-07-24 01:19:13 PDT
Created attachment 153984 [details]
Comment 2 Kenneth Rohde Christiansen 2012-07-24 01:24:46 PDT
Comment on attachment 153984 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=153984&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:164
> +    Ewk_Url_Response *redirect_response; /**< Possible redirect response for the resource (may be @c NULL) */

Redirect response if a redirect occurred or NULL (or similar)
Comment 3 Chris Dumez 2012-07-24 01:30:12 PDT
Created attachment 153985 [details]
Patch for landing

Fixed Kenneth's nit.

Could someone please cq+ ?
Comment 4 WebKit Review Bot 2012-07-24 02:21:55 PDT
Comment on attachment 153985 [details]
Patch for landing

Clearing flags on attachment: 153985

Committed r123444: <http://trac.webkit.org/changeset/123444>
Comment 5 WebKit Review Bot 2012-07-24 02:22:00 PDT
All reviewed patches have been landed.  Closing bug.