RESOLVED FIXED92015
[Qt] Images scale differently in WK1 and WK2 
https://bugs.webkit.org/show_bug.cgi?id=92015
Summary [Qt] Images scale differently in WK1 and WK2
Caio Marcelo de Oliveira Filho
Reported 2012-07-23 12:04:52 PDT
In WK1 the image looks more pixelated, in WK2 more blurry.
Attachments
Output of test produced by Qt with WK1 (59.34 KB, image/png)
2012-07-23 12:14 PDT, Caio Marcelo de Oliveira Filho 		no flags
Details
Output of test produced by Qt with WK2 (184.81 KB, image/png)
2012-07-23 12:15 PDT, Caio Marcelo de Oliveira Filho 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2012-07-23 12:14:50 PDT
Created attachment 153834 [details] Output of test produced by Qt with WK1
Caio Marcelo de Oliveira Filho
Comment 2 2012-07-23 12:15:17 PDT
Created attachment 153835 [details] Output of test produced by Qt with WK2
Caio Marcelo de Oliveira Filho
Comment 3 2012-07-24 12:46:38 PDT
Original test failing is tables/mozilla_expected_failures/bugs/bug85016.html
Caio Marcelo de Oliveira Filho
Comment 4 2012-07-24 12:47:19 PDT
Also: svg/carto.net/scrollbar.svg svg/carto.net/selectionlist.svg
Caio Marcelo de Oliveira Filho
Comment 5 2012-07-24 15:53:59 PDT
fast/block/positioning/replaced-inside-fixed-top-bottom.html
Simon Hausmann
Comment 6 2012-07-25 01:21:46 PDT
Maybe because of #85610 ?
Simon Hausmann
Comment 7 2012-07-25 01:22:05 PDT
Err, bug #85610
Caio Marcelo de Oliveira Filho
Comment 8 2012-07-25 07:55:51 PDT
css2.1/t100304-c43-rpl-bbx-00-d-g.html css2.1/t100304-c43-rpl-bbx-01-d-g.html
Caio Marcelo de Oliveira Filho
Comment 9 2012-07-25 10:10:35 PDT
css2.1/t090501-c414-flt-02-d-g.html css2.1/t090501-c414-flt-03-b-g.html css2.1/t090501-c414-flt-ln-01-d-g.html
Allan Sandfeld Jensen
Comment 10 2012-08-04 06:03:53 PDT
(In reply to comment #7) > Err, bug #85610 That would explain the observed difference perfectly: > In WK1 the image looks more pixelated, in WK2 more blurry. So WebKit1 could change to also use better image-scaling, or scaling quality could be made configurable so that the test-runner can use the same both places.
Jocelyn Turcotte
Comment 11 2012-08-06 03:37:19 PDT
I think the reason that we forced it for WK2 is that we have scaled images more often because of pinch-zooming and that it's not possible to force it through the API. For WK1 you should have 1:1 scaled images most of the time, and if you want SmoothPixmapTransform, you can set the render hint on the QPainter or the QGraphicsView yourself. This has a considerable performance impacts on rendering.
Jocelyn Turcotte
Comment 12 2012-08-06 03:42:50 PDT
(In reply to comment #10) > So WebKit1 could change to also use better image-scaling, or scaling quality could be made configurable so that the test-runner can use the same both places. We could add an explicit configuration flag, or just enable it when flickableViewportEnabled is false if we want to make both behave the same way for tests. I'd prefer not to change the way WK1 behaves.
Jocelyn Turcotte
Comment 13 2012-08-06 03:44:26 PDT
(In reply to comment #12) > ... or just enable it when flickableViewportEnabled is false ... I meant enable it when it's true.
Allan Sandfeld Jensen
Comment 14 2013-11-22 08:56:07 PST
I believe this a side-effect of a bug that messed up the image-smoothing effect in WebKit1. This has been solved in the Qt 5x2 tree.
Note You need to log in before you can comment on or make changes to this bug.