Created attachment 139098 [details] testcase Pressing enter in this list example deletes the whole list Regression from: https://bugs.webkit.org/show_bug.cgi?id=82690 http://trac.webkit.org/changeset/113723 <rdar://problem/11313662>
Excellent! My colleagues and I were investigating this issue but we couldn't get a reduction!
Sorry for causing the regression:( Will look at it and try to fix it ASAP.
Created attachment 139241 [details] first try Will do more manual testing before landing the patch
Comment on attachment 139241 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=139241&action=review > Source/WebCore/editing/CompositeEditCommand.cpp:1272 > + Node* previousListNode = emptyListItem->isElementNode() ? toElement(emptyListItem)->previousElementSibling(): emptyListItem->previousSibling(); > + Node* nextListNode = emptyListItem->isElementNode() ? toElement(emptyListItem)->nextElementSibling(): emptyListItem->nextSibling(); > + if (isListItem(nextListNode) || isListElement(nextListNode)) { Maybe you can use functions in http://trac.webkit.org/browser/trunk/Source/WebCore/editing/InsertListCommand.cpp? > Source/WebCore/editing/CompositeEditCommand.cpp:1273 > // If emptyListItem follows another list item, split the list node. This comment is no longer accurate. Please update. > Source/WebCore/editing/CompositeEditCommand.cpp:1285 > // When emptyListItem does not follow any list item, insert newBlock after the enclosing list node. > // Remove the enclosing node if emptyListItem is the only child; otherwise just remove emptyListItem. > insertNodeAfter(newBlock, listNode); Ditto.
Created attachment 139260 [details] fix the comments
Comment on attachment 139260 [details] fix the comments The fix looks good to me. Thanks for fixing it quickly.
Comment on attachment 139260 [details] fix the comments Clearing flags on attachment: 139260 Committed r115520: <http://trac.webkit.org/changeset/115520>
All reviewed patches have been landed. Closing bug.