Bug 91970 – AuthorShadowDOM for meter element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

We would like to support AuthorShadowDOM for meter element.

[Shinya Kawanaka]

Created attachment 156887 [details]
Patch

[Hajime Morrita]

Comment on attachment 156887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156887&action=review

Please consider the theme-based rendering case where WebKit creates only RenderMeter and creates no renderers for shadows.

> Source/WebCore/html/shadow/MeterShadowElement.h:52
> +class MeterInnerElement : public MeterShadowElement {

Why not inherit directly from HTMLDIvElement?

[Shinya Kawanaka]

(In reply to comment #2)
> (From update of attachment 156887 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156887&action=review
> 
> Please consider the theme-based rendering case where WebKit creates only RenderMeter and creates no renderers for shadows.
> 
> > Source/WebCore/html/shadow/MeterShadowElement.h:52
> > +class MeterInnerElement : public MeterShadowElement {
> 
> Why not inherit directly from HTMLDIvElement?

Since MeterInnerElement is also an element in UserAgentShadowDOM in <meter> element, it seems natural that MeterInnerElement is derived from MeterShadowElement.

[Shinya Kawanaka]

Created attachment 157119 [details]
Patch

[WebKit Review Bot]

Comment on attachment 157119 [details]
Patch

Attachment 157119 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13446984

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/html/meter-user-modify.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
fast/dom/shadow/shadowdom-for-meter-without-appearance.html

[WebKit Review Bot]

Created attachment 157128 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Shinya Kawanaka]

Created attachment 157155 [details]
Patch

[Hajime Morrita]

Comment on attachment 157155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157155&action=review

> Source/WebCore/html/HTMLMeterElement.h:72
> +    RenderMeter* renderMeter() const;

Please mark them virtual explicitly.

[Shinya Kawanaka]

(In reply to comment #8)
> (From update of attachment 157155 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157155&action=review
> 
> > Source/WebCore/html/HTMLMeterElement.h:72
> > +    RenderMeter* renderMeter() const;
> 
> Please mark them virtual explicitly.

This seems willAddAuthroShadowRoot() instead of renderMeter().
I'll update the patch and land it.

[Shinya Kawanaka]

Created attachment 158189 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 158189 [details]
Patch for landing

Clearing flags on attachment: 158189

Committed r125519: <http://trac.webkit.org/changeset/125519>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 93945

[Shinya Kawanaka]

Created attachment 158487 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 158487 [details]
Patch for landing

Attachment 158487 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13490881

New failing tests:
fast/dom/shadow/shadowdom-for-meter-dynamic.html

[WebKit Review Bot]

Created attachment 158499 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Shinya Kawanaka]

(In reply to comment #15)
> (From update of attachment 158487 [details])
> Attachment 158487 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/13490881
> 
> New failing tests:
> fast/dom/shadow/shadowdom-for-meter-dynamic.html

This test also fails in the previous patch (which is that EWS bot were all green).
I think some bug was introduced these days.

[Shinya Kawanaka]

> This test also fails in the previous patch (which is that EWS bot were all green).
> I think some bug was introduced these days.

Oops... This was false.

[Shinya Kawanaka]

Created attachment 158519 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 158519 [details]
Patch for landing

Clearing flags on attachment: 158519

Committed r125659: <http://trac.webkit.org/changeset/125659>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Brady Eidson]

4 of these tests fail on Mac bots.

See http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125711%20(1920)/results.html for those.

[Shinya Kawanaka]

(In reply to comment #22)
> 4 of these tests fail on Mac bots.
> 
> See http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125711%20(1920)/results.html for those.

Just rebaselining should be OK.