Bug 91888 - [Qt] WebViewLoadFavIcon::test_favIconLoad() fails
Summary: [Qt] WebViewLoadFavIcon::test_favIconLoad() fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Brandao
URL:
Keywords:
Depends on:
Blocks: 70236
  Show dependency tree / graph
 
Reported: 2012-07-20 11:58 PDT by Rafael Brandao
Modified: 2012-08-10 09:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2012-07-20 11:59 PDT, Rafael Brandao 		no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2012-07-30 15:03 PDT, Rafael Brandao 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Brandao 2012-07-20 11:58:27 PDT 
[Qt] WebViewLoadFavIcon::test_favIconLoad() fails
Comment 1 Rafael Brandao 2012-07-20 11:59:58 PDT 
Created attachment 153554 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2012-07-20 12:21:08 PDT 
Comment on attachment 153554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153554&action=review

Looks good to me. But I have a question :-)

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:40
>              verify(webView.waitForLoadSucceeded())
> +            spy.wait()

Do we even need to webView.waitForLoadSucceeded here?

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:51
>              verify(webView.waitForLoadSucceeded())
> +            spy.wait()

And here.
Comment 3 Rafael Brandao 2012-07-30 15:03:24 PDT 
Created attachment 155374 [details]
Patch
Comment 4 Rafael Brandao 2012-07-30 15:05:07 PDT 
Makes sense. Unfortunately the bug is no longer showing up on my machine because it's now faster and it seems it's neither showing up on buildbot. But for me it's clear that there's a problem there, so I'm all for upstreaming this patch. :-)
Comment 5 WebKit Review Bot 2012-08-10 09:30:39 PDT 
Comment on attachment 155374 [details]
Patch

Clearing flags on attachment: 155374

Committed r125291: <http://trac.webkit.org/changeset/125291>
Comment 6 WebKit Review Bot 2012-08-10 09:30:42 PDT 
All reviewed patches have been landed.  Closing bug.