Inspector should allow user to delete files and directories on FileSystem.
Created attachment 158245 [details] Patch
Comment on attachment 158245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158245&action=review > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:782 > + ASSERT(m_frontendProvider->frontend()); Nit: consider extracting the following code if (!m_enabled || !m_frontendProvider) { *error = "FileSystem agent is not enabled"; return; } ASSERT(m_frontendProvider->frontend()); So that each protocol command started with if (!assertFrontend(error)) return; This way it should be shorter.
Created attachment 159027 [details] Patch
Comment on attachment 158245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158245&action=review >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:782 >> + ASSERT(m_frontendProvider->frontend()); > > Nit: consider extracting the following code > > if (!m_enabled || !m_frontendProvider) { > *error = "FileSystem agent is not enabled"; > return; > } > ASSERT(m_frontendProvider->frontend()); > > So that each protocol command started with > > if (!assertFrontend(error)) > return; > > This way it should be shorter. Looks nice. Done.
Comment on attachment 159027 [details] Patch Attachment 159027 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13514708
Comment on attachment 159027 [details] Patch Attachment 159027 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13521286
Comment on attachment 159027 [details] Patch Please fix "ReportErrorTask" building error.
Comment on attachment 159027 [details] Patch Oh, I see you are adding it in another patch.
Comment on attachment 159027 [details] Patch Clearing flags on attachment: 159027 Committed r126273: <http://trac.webkit.org/changeset/126273>
All reviewed patches have been landed. Closing bug.