Bug 91814 - Introduce Node::shadowHost()
Summary: Introduce Node::shadowHost()
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
Depends on:
Blocks: 91589
  Show dependency treegraph
Reported: 2012-07-19 21:25 PDT by Kent Tamura
Modified: 2012-07-19 22:54 PDT (History)
3 users (show)

See Also:

Patch (3.45 KB, patch)
2012-07-19 21:41 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-08 (1.30 MB, application/zip)
2012-07-19 22:30 PDT, WebKit Review Bot
no flags Details
Patch 2 (3.51 KB, patch)
2012-07-19 22:39 PDT, Kent Tamura
morrita: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-07-19 21:25:37 PDT
Introduce Node::shadowHost(), which return the host element, or 0.
Comment 1 Kent Tamura 2012-07-19 21:41:29 PDT
Created attachment 153404 [details]
Comment 2 WebKit Review Bot 2012-07-19 22:30:49 PDT
Comment on attachment 153404 [details]

Attachment 153404 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13312126

New failing tests:
Comment 3 WebKit Review Bot 2012-07-19 22:30:52 PDT
Created attachment 153411 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Shinya Kawanaka 2012-07-19 22:34:57 PDT
Comment on attachment 153404 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=153404&action=review

> Source/WebCore/dom/Node.h:228
> +    // If this node is in a shadow tree, returns its shadow host. Otherwise, returns this.

I think we should mention using shadowAncestorNode() is discouraged.

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:85
> +    // alwasys in shadow of <input>.

Comment 5 Kent Tamura 2012-07-19 22:39:57 PDT
Created attachment 153417 [details]
Patch 2

Improve comments
Comment 6 Kent Tamura 2012-07-19 22:54:51 PDT
Committed r123180: <http://trac.webkit.org/changeset/123180>