Bug 91806 - [Tests] Rename fast/forms/number/*.html to number-*.html
Summary: [Tests] Rename fast/forms/number/*.html to number-*.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 91805
  Show dependency tree / graph
 
Reported: 2012-07-19 20:56 PDT by yosin
Modified: 2012-08-02 22:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (718.06 KB, patch)
2012-07-20 02:07 PDT, yosin 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-07-19 20:56:03 PDT 
This bug is a part of fast/forms arrangement.
Comment 1 yosin 2012-07-20 02:07:23 PDT 
Created attachment 153451 [details]
Patch 1
Comment 2 yosin 2012-07-20 02:09:35 PDT 
Comment on attachment 153451 [details]
Patch 1

Could you review this patch?
Thanks in advance.

This is result of "svn move". So, I'll commit from terminal.
Comment 3 Kent Tamura 2012-07-20 02:51:10 PDT 
Will you rename LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton*.html in another patch?
Comment 4 yosin 2012-07-20 02:57:06 PDT 
(In reply to comment #3)
> Will you rename LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton*.html in another patch?

It is out of scope of this bug. This bug is intended for renaming files under LayoutTests/fast/form/numbers/.
Comment 5 yosin 2012-07-20 03:03:27 PDT 
(In reply to comment #3)
> Will you rename LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton*.html in another patch?

In the future, yes.
There are 13 files under LayoutTest/platform/*/fast/forms/.
Comment 6 Kent Tamura 2012-07-20 03:45:21 PDT 
Comment on attachment 153451 [details]
Patch 1

rubber stamped.

Please watch the buildbots for a while after landing this patch.
Comment 7 yosin 2012-07-22 18:05:37 PDT 
Renaming is succeeded:
1. Change set displays entries with "moved from"
2. Individual file entry has "copied from", e.g.
http://trac.webkit.org/log/trunk/LayoutTests/fast/forms/number/number-size.html?rev=123302

I'm watching "Waterfall"
Comment 8 Andrew Wilson 2012-07-23 10:55:07 PDT 
I'm seeing these errors in the webkit lint output:

e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:228 Path does not exist. fast/forms/number/input-appearance-number-rtl.html
e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:229 Path does not exist. fast/forms/number/input-appearance-spinbutton-disabled-readonly.html
e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:230 Path does not exist. fast/forms/number/input-appearance-spinbutton-layer.html
Comment 9 yosin 2012-07-23 19:16:37 PDT 
(In reply to comment #8)
> I'm seeing these errors in the webkit lint output:
> 
> e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:228 Path does not exist. fast/forms/number/input-appearance-number-rtl.html
> e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:229 Path does not exist. fast/forms/number/input-appearance-spinbutton-disabled-readonly.html
> e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:230 Path does not exist. fast/forms/number/input-appearance-spinbutton-layer.html

Thanks Andrew!
I updates skia_test_expectations.txt
http://codereview.chromium.org/10810065