[chromium] CSS tweaks to media controls to prevent styles from being overridden
Created attachment 153382 [details] Patch
Created attachment 153384 [details] Patch
Comment on attachment 153384 [details] Patch Attachment 153384 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13310096 New failing tests: media/media-document-audio-repaint.html media/video-no-audio.html media/controls-strict.html media/controls-styling.html media/video-display-toggle.html media/audio-repaint.html media/audio-controls-rendering.html media/video-zoom-controls.html media/video-controls-rendering.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html media/video-playing-and-pause.html media/controls-after-reload.html
Created attachment 153389 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 153434 [details] Fixes the bug
Comment on attachment 153434 [details] Fixes the bug Oops, sorry I somehow used a wrong bug number.
Comment on attachment 153384 [details] Patch the heck!! :) re-opening for review
Created attachment 153544 [details] Patch
Comment on attachment 153544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153544&action=review > Source/WebCore/ChangeLog:9 > + [chromium] CSS tweaks to media controls to prevent styles from being overridden > + https://bugs.webkit.org/show_bug.cgi?id=91802 > + > + Reviewed by NOBODY (OOPS!). > + > + Test: media/controls-styling-strict.html > + maybe you should comment why it fixes the bug.
Created attachment 153548 [details] Patch
Comment on attachment 153544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153544&action=review >> Source/WebCore/ChangeLog:9 >> + > > maybe you should comment why it fixes the bug. done
LGTM FWIW :-)
Committed r123259: <http://trac.webkit.org/changeset/123259>
*** Bug 89696 has been marked as a duplicate of this bug. ***
(Just adding linkage to meta bug.)