Bug 91802 - [chromium] CSS tweaks to media controls to prevent styles from being overridden
Summary: [chromium] CSS tweaks to media controls to prevent styles from being overridden
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Scherkus
URL:
Keywords:
: 89696 (view as bug list)
Depends on:
Blocks: 84672
  Show dependency treegraph
 
Reported: 2012-07-19 20:28 PDT by Andrew Scherkus
Modified: 2012-08-06 21:15 PDT (History)
9 users (show)

See Also:


Attachments
Patch (48.81 KB, patch)
2012-07-19 20:29 PDT, Andrew Scherkus
no flags Details | Formatted Diff | Diff
Patch (48.69 KB, patch)
2012-07-19 20:32 PDT, Andrew Scherkus
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (458.69 KB, application/zip)
2012-07-19 21:03 PDT, WebKit Review Bot
no flags Details
Fixes the bug (4.51 KB, patch)
2012-07-20 00:29 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch (7.66 KB, patch)
2012-07-20 11:11 PDT, Andrew Scherkus
no flags Details | Formatted Diff | Diff
Patch (7.96 KB, patch)
2012-07-20 11:21 PDT, Andrew Scherkus
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2012-07-19 20:28:25 PDT
[chromium] CSS tweaks to media controls to prevent styles from being overridden
Comment 1 Andrew Scherkus 2012-07-19 20:29:04 PDT
Created attachment 153382 [details]
Patch
Comment 2 Andrew Scherkus 2012-07-19 20:32:38 PDT
Created attachment 153384 [details]
Patch
Comment 3 WebKit Review Bot 2012-07-19 21:03:43 PDT
Comment on attachment 153384 [details]
Patch

Attachment 153384 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13310096

New failing tests:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/controls-strict.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-repaint.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/media-controls-clone.html
fast/layers/video-layer.html
media/video-empty-source.html
media/video-playing-and-pause.html
media/controls-after-reload.html
Comment 4 WebKit Review Bot 2012-07-19 21:03:48 PDT
Created attachment 153389 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 5 Ryosuke Niwa 2012-07-20 00:29:30 PDT
Created attachment 153434 [details]
Fixes the bug
Comment 6 Ryosuke Niwa 2012-07-20 00:30:11 PDT
Comment on attachment 153434 [details]
Fixes the bug

Oops, sorry I somehow used a wrong bug number.
Comment 7 Andrew Scherkus 2012-07-20 10:33:10 PDT
Comment on attachment 153384 [details]
Patch

the heck!! :)

re-opening for review
Comment 8 Andrew Scherkus 2012-07-20 11:11:46 PDT
Created attachment 153544 [details]
Patch
Comment 9 Antonio Gomes 2012-07-20 11:14:38 PDT
Comment on attachment 153544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153544&action=review

> Source/WebCore/ChangeLog:9
> +        [chromium] CSS tweaks to media controls to prevent styles from being overridden
> +        https://bugs.webkit.org/show_bug.cgi?id=91802
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: media/controls-styling-strict.html
> +

maybe you should comment why it fixes the bug.
Comment 10 Andrew Scherkus 2012-07-20 11:21:15 PDT
Created attachment 153548 [details]
Patch
Comment 11 Andrew Scherkus 2012-07-20 11:21:39 PDT
Comment on attachment 153544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153544&action=review

>> Source/WebCore/ChangeLog:9
>> +
> 
> maybe you should comment why it fixes the bug.

done
Comment 12 Silvia Pfeiffer 2012-07-20 11:53:56 PDT
LGTM FWIW :-)
Comment 13 Andrew Scherkus 2012-07-20 14:12:19 PDT
Committed r123259: <http://trac.webkit.org/changeset/123259>
Comment 14 Andrew Scherkus 2012-07-20 14:13:41 PDT
*** Bug 89696 has been marked as a duplicate of this bug. ***
Comment 15 Silvia Pfeiffer 2012-08-06 21:15:16 PDT
(Just adding linkage to meta bug.)