RESOLVED FIXED 91767
ColorChooserClient should expose the element's location 
https://bugs.webkit.org/show_bug.cgi?id=91767
Summary ColorChooserClient should expose the element's location
Pierre Rossi
Reported 2012-07-19 11:52:16 PDT
ColorChooserClient should expose the element's location
Attachments
Patch (4.29 KB, patch)
2012-07-19 11:55 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (25.79 KB, patch)
2012-07-19 12:06 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (3.34 KB, patch)
2012-07-20 03:25 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (3.30 KB, patch)
2012-07-20 06:40 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Pierre Rossi
Comment 1 2012-07-19 11:55:51 PDT
Created attachment 153317 [details] Patch
Pierre Rossi
Comment 2 2012-07-19 12:06:28 PDT
Created attachment 153319 [details] Patch
WebKit Review Bot
Comment 3 2012-07-19 12:08:47 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Review Bot
Comment 4 2012-07-19 12:23:57 PDT
Comment on attachment 153319 [details] Patch Attachment 153319 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13274944
Pierre Rossi
Comment 5 2012-07-20 03:25:15 PDT
Created attachment 153464 [details] Patch
Kent Tamura
Comment 6 2012-07-20 03:26:46 PDT
Comment on attachment 153464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153464&action=review > Source/WebCore/html/ColorInputType.h:37 > +#include "IntRect.h" IntRect.h should be included in ColorChooserClient.h.
Kent Tamura
Comment 7 2012-07-20 03:28:54 PDT
Comment on attachment 153464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153464&action=review > Source/WebCore/html/ColorInputType.cpp:204 > + return pixelSnappedIntRect(renderer->view()->frameView()->contentsToWindow(renderer->absoluteBoundingBoxRectIgnoringTransforms())); Why ignoringTransofrms ?
Pierre Rossi
Comment 8 2012-07-20 06:40:48 PDT
Created attachment 153492 [details] Patch
Kent Tamura
Comment 9 2012-07-20 06:43:28 PDT
Comment on attachment 153492 [details] Patch Looks good.
WebKit Review Bot
Comment 10 2012-07-20 07:23:55 PDT
Comment on attachment 153492 [details] Patch Clearing flags on attachment: 153492 Committed r123214: <http://trac.webkit.org/changeset/123214>
WebKit Review Bot
Comment 11 2012-07-20 07:24:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.