ColorChooserClient should expose the element's location
Created attachment 153317 [details] Patch
Created attachment 153319 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 153319 [details] Patch Attachment 153319 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13274944
Created attachment 153464 [details] Patch
Comment on attachment 153464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153464&action=review > Source/WebCore/html/ColorInputType.h:37 > +#include "IntRect.h" IntRect.h should be included in ColorChooserClient.h.
Comment on attachment 153464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153464&action=review > Source/WebCore/html/ColorInputType.cpp:204 > + return pixelSnappedIntRect(renderer->view()->frameView()->contentsToWindow(renderer->absoluteBoundingBoxRectIgnoringTransforms())); Why ignoringTransofrms ?
Created attachment 153492 [details] Patch
Comment on attachment 153492 [details] Patch Looks good.
Comment on attachment 153492 [details] Patch Clearing flags on attachment: 153492 Committed r123214: <http://trac.webkit.org/changeset/123214>
All reviewed patches have been landed. Closing bug.