Bug 91664 - [WK2] expose element rect for color input type
Summary: [WK2] expose element rect for color input type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pierre Rossi
URL:
Keywords:
Depends on: 91767
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-18 13:41 PDT by Pierre Rossi
Modified: 2012-09-09 10:22 PDT (History)
15 users (show)

See Also:


Attachments
Patch (24.72 KB, patch)
2012-07-18 14:18 PDT, Pierre Rossi
no flags Details | Formatted Diff | Diff
Patch (21.53 KB, patch)
2012-07-20 06:42 PDT, Pierre Rossi
no flags Details | Formatted Diff | Diff
Patch (21.48 KB, patch)
2012-07-20 08:36 PDT, Pierre Rossi
no flags Details | Formatted Diff | Diff
Patch (21.48 KB, patch)
2012-09-07 12:59 PDT, Pierre Rossi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Rossi 2012-07-18 13:41:06 PDT
[Qt][WK2] expose element rect for color input type
Comment 1 Pierre Rossi 2012-07-18 14:18:22 PDT
Created attachment 153085 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-18 14:21:48 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alexis Menard (darktears) 2012-07-18 14:32:53 PDT
Comment on attachment 153085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review

> Source/WebCore/ChangeLog:3
> +        [Qt][WK2] expose element rect for color input type

You should rename the bug. You modify other files than Qt so [Qt] is not correct here.
Comment 4 WebKit Review Bot 2012-07-18 14:37:45 PDT
Comment on attachment 153085 [details]
Patch

Attachment 153085 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13271715
Comment 5 Kent Tamura 2012-07-18 16:35:01 PDT
Comment on attachment 153085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review

You had better split the patch into the WebCore part and the WebKit2 part.

> Source/WebCore/platform/ColorChooserClient.h:20
> +    virtual IntRect elementRect() const = 0;

Need a comment about rect in what; in frame? in RootView? in window? in screen?
Or rename the function like elementRectInWindow()
Comment 6 Pierre Rossi 2012-07-20 06:42:13 PDT
Created attachment 153493 [details]
Patch
Comment 7 Gyuyoung Kim 2012-07-20 06:49:43 PDT
Comment on attachment 153493 [details]
Patch

Attachment 153493 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13318067
Comment 8 Early Warning System Bot 2012-07-20 07:07:27 PDT
Comment on attachment 153493 [details]
Patch

Attachment 153493 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13308282
Comment 9 Pierre Rossi 2012-07-20 08:35:07 PDT
Comment on attachment 153493 [details]
Patch

Was a bit hasty in updating this patch before the commit-queue landed r123214.
Comment 10 Pierre Rossi 2012-07-20 08:36:42 PDT
Created attachment 153510 [details]
Patch
Comment 11 Pierre Rossi 2012-07-27 05:39:41 PDT
Comment on attachment 153510 [details]
Patch

Patch needs to be updated to follow change in https://bugs.webkit.org/show_bug.cgi?id=92488.
Comment 12 Pierre Rossi 2012-09-07 12:59:50 PDT
Created attachment 162850 [details]
Patch
Comment 13 WebKit Review Bot 2012-09-09 10:22:36 PDT
Comment on attachment 162850 [details]
Patch

Clearing flags on attachment: 162850

Committed r127988: <http://trac.webkit.org/changeset/127988>
Comment 14 WebKit Review Bot 2012-09-09 10:22:41 PDT
All reviewed patches have been landed.  Closing bug.