[Qt][WK2] expose element rect for color input type
Created attachment 153085 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 153085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review > Source/WebCore/ChangeLog:3 > + [Qt][WK2] expose element rect for color input type You should rename the bug. You modify other files than Qt so [Qt] is not correct here.
Comment on attachment 153085 [details] Patch Attachment 153085 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13271715
Comment on attachment 153085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review You had better split the patch into the WebCore part and the WebKit2 part. > Source/WebCore/platform/ColorChooserClient.h:20 > + virtual IntRect elementRect() const = 0; Need a comment about rect in what; in frame? in RootView? in window? in screen? Or rename the function like elementRectInWindow()
Created attachment 153493 [details] Patch
Comment on attachment 153493 [details] Patch Attachment 153493 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13318067
Comment on attachment 153493 [details] Patch Attachment 153493 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13308282
Comment on attachment 153493 [details] Patch Was a bit hasty in updating this patch before the commit-queue landed r123214.
Created attachment 153510 [details] Patch
Comment on attachment 153510 [details] Patch Patch needs to be updated to follow change in https://bugs.webkit.org/show_bug.cgi?id=92488.
Created attachment 162850 [details] Patch
Comment on attachment 162850 [details] Patch Clearing flags on attachment: 162850 Committed r127988: <http://trac.webkit.org/changeset/127988>
All reviewed patches have been landed. Closing bug.