RESOLVED FIXED 91664
[WK2] expose element rect for color input type 
https://bugs.webkit.org/show_bug.cgi?id=91664
Summary [WK2] expose element rect for color input type
Pierre Rossi
Reported 2012-07-18 13:41:06 PDT
[Qt][WK2] expose element rect for color input type
Attachments
Patch (24.72 KB, patch)
2012-07-18 14:18 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (21.53 KB, patch)
2012-07-20 06:42 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (21.48 KB, patch)
2012-07-20 08:36 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (21.48 KB, patch)
2012-09-07 12:59 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Pierre Rossi
Comment 1 2012-07-18 14:18:22 PDT
Created attachment 153085 [details] Patch
WebKit Review Bot
Comment 2 2012-07-18 14:21:48 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alexis Menard (darktears)
Comment 3 2012-07-18 14:32:53 PDT
Comment on attachment 153085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review > Source/WebCore/ChangeLog:3 > + [Qt][WK2] expose element rect for color input type You should rename the bug. You modify other files than Qt so [Qt] is not correct here.
WebKit Review Bot
Comment 4 2012-07-18 14:37:45 PDT
Comment on attachment 153085 [details] Patch Attachment 153085 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13271715
Kent Tamura
Comment 5 2012-07-18 16:35:01 PDT
Comment on attachment 153085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review You had better split the patch into the WebCore part and the WebKit2 part. > Source/WebCore/platform/ColorChooserClient.h:20 > + virtual IntRect elementRect() const = 0; Need a comment about rect in what; in frame? in RootView? in window? in screen? Or rename the function like elementRectInWindow()
Pierre Rossi
Comment 6 2012-07-20 06:42:13 PDT
Created attachment 153493 [details] Patch
Gyuyoung Kim
Comment 7 2012-07-20 06:49:43 PDT
Comment on attachment 153493 [details] Patch Attachment 153493 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13318067
Early Warning System Bot
Comment 8 2012-07-20 07:07:27 PDT
Comment on attachment 153493 [details] Patch Attachment 153493 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13308282
Pierre Rossi
Comment 9 2012-07-20 08:35:07 PDT
Comment on attachment 153493 [details] Patch Was a bit hasty in updating this patch before the commit-queue landed r123214.
Pierre Rossi
Comment 10 2012-07-20 08:36:42 PDT
Created attachment 153510 [details] Patch
Pierre Rossi
Comment 11 2012-07-27 05:39:41 PDT
Comment on attachment 153510 [details] Patch Patch needs to be updated to follow change in https://bugs.webkit.org/show_bug.cgi?id=92488.
Pierre Rossi
Comment 12 2012-09-07 12:59:50 PDT
Created attachment 162850 [details] Patch
WebKit Review Bot
Comment 13 2012-09-09 10:22:36 PDT
Comment on attachment 162850 [details] Patch Clearing flags on attachment: 162850 Committed r127988: <http://trac.webkit.org/changeset/127988>
WebKit Review Bot
Comment 14 2012-09-09 10:22:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.