Bug 91626 – [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Martin Jansa]

GTK version was bumped in https://bugs.webkit.org/show_bug.cgi?id=90332, but EFL is using cmake so bump it there too.

[Martin Jansa]

Created attachment 153011 [details]
OptionsEfl: bump libsoup requirements like autotools did in r121772

[Thiago Marcos P. Santos]

LGTM

[Thiago Marcos P. Santos]

(In reply to comment #2)
> LGTM

But you have to write a changelog. :)

[Chris Dumez]

Comment on attachment 153011 [details]
OptionsEfl: bump libsoup requirements like autotools did in r121772

View in context: https://bugs.webkit.org/attachment.cgi?id=153011&action=review

I'm in the middle of something but I can take over this patch soon if needed.

> Source/cmake/OptionsEfl.cmake:38
> +FIND_PACKAGE(LibSoup2 2.39.2 REQUIRED)

We actually need 2.39.3.

[Chris Dumez]

Created attachment 153062 [details]
Patch

The first tarball to contain the API we need is definitely v2.39.3 (not 2.39.2) although the version tag in GIT to contain the API is LIBSOUP_2_39_2 (Misleading):
- http://ftp.acc.umu.se/pub/gnome/sources/libsoup/2.39/libsoup-2.39.3.news (Second bullet)

I bumped the dependency in CMake and I also had to update our jhbuild config to pull in the v2.39.3 tarball as well since the GIT tag we where using was still versioned 2.39.2. This way we match the CMake requirements.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 153062 [details]
Patch

Looks good, thanks for looking at this.

[Thiago Marcos P. Santos]

LGTM. Thanks Christophe!

[WebKit Review Bot]

Comment on attachment 153062 [details]
Patch

Clearing flags on attachment: 153062

Committed r123069: <http://trac.webkit.org/changeset/123069>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.