Bug 91601 - Regression (r122913) webkitpy tests are failing
Summary: Regression (r122913) webkitpy tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 91542
  Show dependency tree / graph
 
Reported: 2012-07-18 01:12 PDT by Thiago Marcos P. Santos
Modified: 2012-07-18 01:39 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2012-07-18 01:18 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-07-18 01:12:49 PDT 
[0/1447] webkit2.messages_unittest.HeaderTest.test_header
[689/1447] webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_broken_pipe erred:
  Traceback (most recent call last):
    File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py", line 129, in test_broken_pipe
      server_process.write("should break")
    File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/server_process.py", line 144, in write
      self.stop()
    File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/server_process.py", line 331, in stop
      timeout = time.time() + self._port.process_kill_time()
  AttributeError: 'TrivialMockPort' object has no attribute 'process_kill_time'
Comment 1 Thiago Marcos P. Santos 2012-07-18 01:18:09 PDT 
Created attachment 152959 [details]
Patch
Comment 2 Kristóf Kosztyó 2012-07-18 01:23:55 PDT 
Sorry I didn't notice that you working on this. I was already done this in r122913 (http://trac.webkit.org/changeset/122932)
Comment 3 Kristóf Kosztyó 2012-07-18 01:26:49 PDT 
(In reply to comment #2)
> Sorry I didn't notice that you working on this. I was already done this in r122913 (http://trac.webkit.org/changeset/122932)

And I have some problems with the numbers :) r122932
Comment 4 Thiago Marcos P. Santos 2012-07-18 01:39:42 PDT 
(In reply to comment #2)
> Sorry I didn't notice that you working on this. I was already done this in r122913 (http://trac.webkit.org/changeset/122932)

No problem. But maybe next time would be nice to follow the standard patch submitting flow to avoid this kind of duplication.