RESOLVED FIXED 91542
NRWT The time before server_process kills DRT should be variable 
https://bugs.webkit.org/show_bug.cgi?id=91542
Summary NRWT The time before server_process kills DRT should be variable
Don Olmstead
Reported 2012-07-17 14:15:19 PDT
Currently NRWT will attempt to kill a DRT process after 3 seconds. This is hard coded within the stop method in server_process. Ports should be able to specify the amount of time before killing the process in case more time is needed for cleanup to complete.
Attachments
Patch (64.81 KB, patch)
2012-07-17 14:22 PDT, Don Olmstead 		dpranke: review-
dpranke: commit-queue-
DetailsFormatted DiffDiff
Patch (2.98 KB, patch)
2012-07-17 17:42 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2012-07-17 14:22:12 PDT
Created attachment 152829 [details] Patch
WebKit Review Bot
Comment 2 2012-07-17 14:25:29 PDT
Attachment 152829 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/port/base.py:1024: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Pranke
Comment 3 2012-07-17 15:49:03 PDT
Comment on attachment 152829 [details] Patch the python change itself looks fine. Fix the style complaint and your webkitpy.pyproj diff ... in fact, you should probably make the .pyproj change a separate change if you can.
Don Olmstead
Comment 4 2012-07-17 17:42:15 PDT
Created attachment 152887 [details] Patch
WebKit Review Bot
Comment 5 2012-07-17 18:26:37 PDT
Comment on attachment 152887 [details] Patch Clearing flags on attachment: 152887 Committed r122913: <http://trac.webkit.org/changeset/122913>
WebKit Review Bot
Comment 6 2012-07-17 18:26:41 PDT
All reviewed patches have been landed. Closing bug.
Peter Gal
Comment 7 2012-07-18 00:18:48 PDT
This resulted a python test to fail: http://build.webkit.org/builders/Qt%20Linux%20Release/builds/49647/steps/webkitpy-test/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.