Bug 91486 – A shadow element in ShadowDOM of a button element does not work.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

When we add an AuthorShadowDOM to button element, it should be rendered correctly.

[Shinya Kawanaka]

Created attachment 158485 [details]
WIP

[WebKit Review Bot]

Attachment 158485 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/html/HTMLButtonElement.cpp:48:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13510024

[Build Bot]

Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13501489

[Gyuyoung Kim]

Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13490869

[Early Warning System Bot]

Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13510037

[Early Warning System Bot]

Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13503500

[Shinya Kawanaka]

Created attachment 159617 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159617 [details]
Patch

Attachment 159617 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13546274

New failing tests:
fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html

[WebKit Review Bot]

Created attachment 159623 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Shinya Kawanaka]

Created attachment 159660 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 159660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159660&action=review

> Source/WebCore/ChangeLog:10
> +        So we have to prevent from creating UserAgentShadowDOM.

... prevent it from ...

[Shinya Kawanaka]

Created attachment 159816 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 159816 [details]
Patch for landing

Clearing flags on attachment: 159816

Committed r126248: <http://trac.webkit.org/changeset/126248>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.