Bug 91485 – AuthorShadowDOM support for textarea element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

When we add an AuthorShadowDOM to textarea element, it should be rendered correctly.

[Shinya Kawanaka]

Created attachment 160937 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160937 [details]
Patch

Rejecting attachment 160937 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 160937 [details]
Patch

Rejecting attachment 160937 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Dimitri Glazkov (Google)]

(In reply to comment #2)
> (From update of attachment 160937 [details])
> Rejecting attachment 160937 [details] from review queue.
> 
> [e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

Don't make me come over there.

[Shinya Kawanaka]

Created attachment 161385 [details]
Patch for landing

[Shinya Kawanaka]

EWS was insane... Try again.

[WebKit Review Bot]

Comment on attachment 161385 [details]
Patch for landing

Clearing flags on attachment: 161385

Committed r127108: <http://trac.webkit.org/changeset/127108>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mikhail Pozdnyakov]

Those still fail on EFL:
fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html
fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html


http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug/r127116%20%285136%29/results.html

Corresponding bug is bug95439.

[Philip Rogers]

Shinya and Dimitri, I think this patch failed some tests because it needed some platform-specific results. I went ahead and landed them because nobody was available on IRC: http://trac.webkit.org/changeset/127182