nrwt: move the bulk of the "expected" output to printing.py
Created attachment 152640 [details] Patch
Comment on attachment 152640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152640&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:421 > + self._printer._print_expected(tests_run_msg) Calling a private method here. This should probably be print_expected and print_expected below should be something like...print_expected_details or something.
(In reply to comment #2) > (From update of attachment 152640 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152640&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:421 > > + self._printer._print_expected(tests_run_msg) > > Calling a private method here. This should probably be print_expected and print_expected below should be something like...print_expected_details or something. That gets fixed in https://bugs.webkit.org/show_bug.cgi?id=91447 , where these messages turn into _log.debug(). Is it okay to leave this as-is for the moment, or should I merge the other patch into this one, or would you prefer I rename the methods as you suggest?
Comment on attachment 152640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152640&action=review >>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:421 >>> + self._printer._print_expected(tests_run_msg) >> >> Calling a private method here. This should probably be print_expected and print_expected below should be something like...print_expected_details or something. > > That gets fixed in https://bugs.webkit.org/show_bug.cgi?id=91447 , where these messages turn into _log.debug(). Is it okay to leave this as-is for the moment, or should I merge the other patch into this one, or would you prefer I rename the methods as you suggest? I see. Given that I've already r+'ed the other patch, I think it's fine. :)
Committed r122887: <http://trac.webkit.org/changeset/122887>