Bug 91447 - nrwt: clean up logging when we're only running one chunk of the tests
Summary: nrwt: clean up logging when we're only running one chunk of the tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-16 17:05 PDT by Dirk Pranke
Modified: 2012-07-17 16:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2012-07-16 17:06 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-16 17:05:23 PDT 
nrwt: clean up logging when we're only running one chunk of the tests
Comment 1 Dirk Pranke 2012-07-16 17:06:41 PDT 
Created attachment 152647 [details]
Patch
Comment 2 Ojan Vafai 2012-07-17 13:34:17 PDT 
Comment on attachment 152647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152647&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-431
> -        tests_run_filename = self._filesystem.join(self._results_directory, "tests_run.txt")

The valgrind layout tests bots used to use this IIRC in order to know which chunk to run next. I suppose we can get rid of it for now since noone seems to be using it. I suppose it's silly for this to be in RWT. The bot itself should just read the stdio log and maintain this information itself if it needs it.
Comment 3 Dirk Pranke 2012-07-17 16:18:58 PDT 
Committed r122892: <http://trac.webkit.org/changeset/122892>