Bug 91363 – REGRESSION(r122681): Patch introduces crashes in debug builds for GTK and EFL ports (Requested by zdobersek on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/122681 broke the build:
Patch introduces crashes in debug builds for GTK and EFL ports (Requested by zdobersek on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 152490 [details]
ROLLOUT of r122681

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Zan Dobersek]

Here's the crash log from the EFL builder, GTK crashes in the same way. I'm happy to help out by testing any potential fixes.

crash log for DumpRenderTree (pid 26046):
STDOUT: <empty>
STDERR: SHOULD NEVER BE REACHED
STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/ScrollableArea.h(136) : virtual WebCore::IntPoint WebCore::ScrollableArea::scrollPosition() const
STDERR: 1   0x7fa34467cd72 WebCore::ScrollableArea::scrollPosition() const
STDERR: 2   0x7fa34467c272 WebCore::ScrollableArea::scrollPositionChanged(WebCore::IntPoint const&)
STDERR: 3   0x7fa34467c533 WebCore::ScrollableArea::setScrollOffsetFromAnimation(WebCore::IntPoint const&)
STDERR: 4   0x7fa34467bc4b WebCore::ScrollAnimator::notifyPositionChanged()
STDERR: 5   0x7fa34467b5e3 WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&)
STDERR: 6   0x7fa34467c12c WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&)
STDERR: 7   0x7fa34467c1f2 WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::ScrollbarOrientation, float)
STDERR: 8   0x7fa34487a2fa WebCore::RenderListBox::computeLogicalHeight()
STDERR: 9   0x7fa34477d7ee WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 10  0x7fa34477cabe WebCore::RenderBlock::layout()
STDERR: 11  0x7fa344879736 WebCore::RenderListBox::layout()
STDERR: 12  0x7fa344751519 WebCore::RenderObject::layoutIfNeeded()
STDERR: 13  0x7fa3447cff79 WebCore::RenderBlock::LineBreaker::nextLineBreak(WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::LineInfo&, std::pair<WebCore::RenderText*, WebCore::LazyLineBreakIterator>&, WebCore::RenderBlock::FloatingObject*, unsigned int)
STDERR: 14  0x7fa3447ca421 WebCore::RenderBlock::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int)
STDERR: 15  0x7fa3447ca09b WebCore::RenderBlock::layoutRunsAndFloats(WebCore::LineLayoutState&, bool)
STDERR: 16  0x7fa3447cc234 WebCore::RenderBlock::layoutInlineChildren(bool, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 17  0x7fa34477d5ab WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 18  0x7fa34477cabe WebCore::RenderBlock::layout()
STDERR: 19  0x7fa3447828ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 20  0x7fa3447823b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&)
STDERR: 21  0x7fa34477d5cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 22  0x7fa34477cabe WebCore::RenderBlock::layout()
STDERR: 23  0x7fa3447828ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 24  0x7fa3447823b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&)
STDERR: 25  0x7fa34477d5cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 26  0x7fa34477cabe WebCore::RenderBlock::layout()
STDERR: 27  0x7fa3447828ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 28  0x7fa3447823b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&)
STDERR: 29  0x7fa34477d5cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 30  0x7fa34477cabe WebCore::RenderBlock::layout()
STDERR: 31  0x7fa3448f6cc4 WebCore::RenderView::layout()

[WebKit Review Bot]

Comment on attachment 152490 [details]
ROLLOUT of r122681

Clearing flags on attachment: 152490

Committed r122701: <http://trac.webkit.org/changeset/122701>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #2)
> Here's the crash log from the EFL builder, GTK crashes in the same way. I'm happy to help out by testing any potential fixes.

Did you try the one attached to bug 91359?

(In reply to comment #5)
> (In reply to comment #2)
> > Here's the crash log from the EFL builder, GTK crashes in the same way. I'm happy to help out by testing any potential fixes.
> 
> Did you try the one attached to bug 91359?

Never mind. Looking at the backtrace, it's obvious that that won't help.