Bug 91359 – REGRESSION (r122681): css3/flexbox/flexbox-overflow-auto.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

After http://trac.webkit.org/r122681 the following ref test is failing:
  css3/flexbox/flexbox-overflow-auto.html

The reason for the failure is that a few scrollbars are no longer in their expected position:
http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release/r122681%20(2660)/css3/flexbox/flexbox-overflow-auto-diffs.html

The issue reproduces on OS X as well when overlay scroll bars are disabled.

[Chris Dumez]

Skipping the test for EFL port in Bug 91360. Please unskip with proper fix, thanks.

Created attachment 152479 [details]
Only skip notifyContentAreaScrolled() if the scroll position doesn’t change

[Chris Dumez]

On the EFL debug bot, a lot of tests started crashing after r122681:
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2819

I haven't tested if the proposed patch fixes the crash in debug mode as well.

backtrace:
crash log for DumpRenderTree (pid 25888):
STDOUT: <empty>
STDERR: SHOULD NEVER BE REACHED
STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/ScrollableArea.h(136) : virtual WebCore::IntPoint WebCore::ScrollableArea::scrollPosition() const
STDERR: 1   0x7fa26f7e8d72 WebCore::ScrollableArea::scrollPosition() const
STDERR: 2   0x7fa26f7e8272 WebCore::ScrollableArea::scrollPositionChanged(WebCore::IntPoint const&)
STDERR: 3   0x7fa26f7e8533 WebCore::ScrollableArea::setScrollOffsetFromAnimation(WebCore::IntPoint const&)
STDERR: 4   0x7fa26f7e7c4b WebCore::ScrollAnimator::notifyPositionChanged()
STDERR: 5   0x7fa26f7e75e3 WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&)
STDERR: 6   0x7fa26f7e812c WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&)
STDERR: 7   0x7fa26f7e81f2 WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::ScrollbarOrientation, float)
STDERR: 8   0x7fa26f9e62fa WebCore::RenderListBox::computeLogicalHeight()
STDERR: 9   0x7fa26f8e97ee WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 10  0x7fa26f8e8abe WebCore::RenderBlock::layout()
STDERR: 11  0x7fa26f9e5736 WebCore::RenderListBox::layout()
STDERR: 12  0x7fa26f8bd519 WebCore::RenderObject::layoutIfNeeded()
STDERR: 13  0x7fa26f93bf79 WebCore::RenderBlock::LineBreaker::nextLineBreak(WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::LineInfo&, std::pair<WebCore::RenderText*, WebCore::LazyLineBreakIterator>&, WebCore::RenderBlock::FloatingObject*, unsigned int)
STDERR: 14  0x7fa26f936421 WebCore::RenderBlock::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int)
STDERR: 15  0x7fa26f93609b WebCore::RenderBlock::layoutRunsAndFloats(WebCore::LineLayoutState&, bool)
STDERR: 16  0x7fa26f938234 WebCore::RenderBlock::layoutInlineChildren(bool, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 17  0x7fa26f8e95ab WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 18  0x7fa26f8e8abe WebCore::RenderBlock::layout()
STDERR: 19  0x7fa26f8ee8ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 20  0x7fa26f8ee3b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&)
STDERR: 21  0x7fa26f8e95cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 22  0x7fa26f8e8abe WebCore::RenderBlock::layout()
STDERR: 23  0x7fa26f8ee8ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 24  0x7fa26f8ee3b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&)
STDERR: 25  0x7fa26f8e95cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 26  0x7fa26f8e8abe WebCore::RenderBlock::layout()
STDERR: 27  0x7fa26f8ee8ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&)
STDERR: 28  0x7fa26f8ee3b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&)
STDERR: 29  0x7fa26f8e95cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit)
STDERR: 30  0x7fa26f8e8abe WebCore::RenderBlock::layout()
STDERR: 31  0x7fa26fa62cc4 WebCore::RenderView::layout()

This has been fixed in <http://trac.webkit.org/r122701> by reverting r122681.