RESOLVED INVALID 90978
[Qt] needs libWebCoreTestSupport 
https://bugs.webkit.org/show_bug.cgi?id=90978
Summary [Qt] needs libWebCoreTestSupport
Balazs Kelemen
Reported 2012-07-11 06:29:17 PDT
So far we exposed testing facilities via DumpRenderTreeSupportQt. This is not sufficient because it leaks public symbols to the library and we also want to expose cross-platform things, like WebCoreTestSupport. We should reuse other ports solution which is a separate non-product helper lib.
Attachments
Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2012-07-11 06:29:47 PDT
*** Bug 90346 has been marked as a duplicate of this bug. ***
Simon Hausmann
Comment 2 2012-07-11 07:34:19 PDT
I think it's a good idea to take the test supporting code out of WebKit/qt and into a more central place. Do you intend to have this library as a static library that is linked into the QtWebKit shared library and exports the necessary symbols?
Balazs Kelemen
Comment 3 2012-07-11 08:24:04 PDT
(In reply to comment #2) > I think it's a good idea to take the test supporting code out of WebKit/qt and into a more central place. > > Do you intend to have this library as a static library that is linked into the QtWebKit shared library and exports the necessary symbols? I did not managed to look into this closely yet but I think we should not link it into QtWebKit. I think it should be a static library that links to QtWebKit which we can we link into drt/wtr.
Jesus Sanchez-Palencia
Comment 4 2012-08-22 13:19:20 PDT
(In reply to comment #3) > I did not managed to look into this closely yet but I think we should not link it into QtWebKit. I think it should be a static library that links to QtWebKit which we can we link into drt/wtr. Are you working on this, Balazs?
Balazs Kelemen
Comment 5 2012-08-23 04:44:03 PDT
(In reply to comment #4) > (In reply to comment #3) > > I did not managed to look into this closely yet but I think we should not link it into QtWebKit. I think it should be a static library that links to QtWebKit which we can we link into drt/wtr. > > Are you working on this, Balazs? No, feel free to pick it up. Btw I think first we should solve bug 90262.
Jocelyn Turcotte
Comment 6 2014-02-03 03:21:37 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.