Bug 90953 – [WK2][EFL] Add policy client to Ewk_View

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

We need to support policy decisions in Ewk_View by defining a policy client and attaching it to the Ewk_View.

[Chris Dumez]

Created attachment 151691 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 151691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44
> +    bool madePolicyDecision;

isnt it more like it is accepted? "didAccept"?

> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.h:46
> +    EWK_NAVIGATION_TYPE_LINK_CLICKED,

I prefer LINK_ACTIVATED especially since it covers a linked being tapped by a finger

[Chris Dumez]

Comment on attachment 151691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44
>> +    bool madePolicyDecision;
> 
> isnt it more like it is accepted? "didAccept"?

No, we want to know if "any" decision was made by the client (accept, reject or download). This is needed, to make a default policy decision ("accept" in this patch) in the case the client did not make an explicit decision.

>> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.h:46
>> +    EWK_NAVIGATION_TYPE_LINK_CLICKED,
> 
> I prefer LINK_ACTIVATED especially since it covers a linked being tapped by a finger

Good point. I will fix this and reupload.

[Chris Dumez]

Created attachment 151871 [details]
Patch

Take Kenneth's feedback into consideration.

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> (From update of attachment 151691 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44
> >> +    bool madePolicyDecision;
> > 
> > isnt it more like it is accepted? "didAccept"?
> 
> No, we want to know if "any" decision was made by the client (accept, reject or download). This is needed, to make a default policy decision ("accept" in this patch) in the case the client did not make an explicit decision.

bool clientTookDecision; might be a bit more clear

or actedUponByClient..

[Chris Dumez]

Comment on attachment 151691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review

>>>> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44
>>>> +    bool madePolicyDecision;
>>> 
>>> isnt it more like it is accepted? "didAccept"?
>> 
>> No, we want to know if "any" decision was made by the client (accept, reject or download). This is needed, to make a default policy decision ("accept" in this patch) in the case the client did not make an explicit decision.
> 
> bool clientTookDecision; might be a bit more clear
> 
> or actedUponByClient..

Ok, I'll clarify.

[Chris Dumez]

Created attachment 151873 [details]
Patch

Take Kenneth's feedback into consideration.

[WebKit Review Bot]

Comment on attachment 151873 [details]
Patch

Clearing flags on attachment: 151873

Committed r122426: <http://trac.webkit.org/changeset/122426>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.