Bug 90904 - [Chromium-Android] Fix typos in chromium_android.py in r151492
Summary: [Chromium-Android] Fix typos in chromium_android.py in r151492
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks: 90894
  Show dependency tree / graph
 
Reported: 2012-07-10 13:37 PDT by Xianzhu Wang
Modified: 2012-07-10 16:06 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2012-07-10 13:43 PDT, Xianzhu Wang 		ojan: review+
wangxianzhu: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-07-10 13:37:43 PDT 
Sorry, I uploaded a wrong version of patch in bug 90894 which contains some typos. Will fix in this one.
Comment 1 Xianzhu Wang 2012-07-10 13:43:56 PDT 
Created attachment 151511 [details]
Patch
Comment 2 Xianzhu Wang 2012-07-10 14:10:28 PDT 
Comment on attachment 151511 [details]
Patch

I'll submit it manually.
Comment 3 Xianzhu Wang 2012-07-10 14:13:55 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Tools/ChangeLog
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
Committed r122261
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
	M	Tools/ChangeLog
r122261 = 213610f62c21101498758f42dcd5ab11851bf576 (refs/remotes/origin/master)
No changes between current HEAD and refs/remotes/origin/master
Resetting to the latest refs/remotes/origin/master
Comment 4 Thiago Marcos P. Santos 2012-07-10 15:04:18 PDT 
It still doesn't solve all the problems:

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2613/steps/webkitpy-test/logs/stdio

./Tools/Scripts/test-webkitpy is still failing.
Comment 5 Xianzhu Wang 2012-07-10 16:06:11 PDT 
(In reply to comment #4)
> It still doesn't solve all the problems:
> 
> http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2613/steps/webkitpy-test/logs/stdio
> 
> ./Tools/Scripts/test-webkitpy is still failing.

Thanks for report. Fixed in r122273. Apology for making so many mistakes (and again the bad commit message).