Bug 90894 - [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment
Summary: [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on: 90904
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-10 10:33 PDT by Xianzhu Wang
Modified: 2012-07-10 13:59 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.59 KB, patch)
2012-07-10 11:16 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-07-10 10:33:43 PDT 
start_helper() is actually start_pixel_test_helper() since http://trac.webkit.org/changeset/115601 (bug 81729).
Should use setup_test_runner() to setup test environment for chromium-android.
Comment 1 Xianzhu Wang 2012-07-10 11:16:24 PDT 
Created attachment 151492 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-10 12:56:54 PDT 
Comment on attachment 151492 [details]
Patch

Clearing flags on attachment: 151492

Committed r122251: <http://trac.webkit.org/changeset/122251>
Comment 3 WebKit Review Bot 2012-07-10 12:56:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Thiago Marcos P. Santos 2012-07-10 13:55:02 PDT 
This patch broke EFL test runner:

Traceback (most recent call last):
  File "./Tools/Scripts/test-webkitpy", line 64, in <module>
    sys.exit(not tester.run())
  File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/test/main.py", line 146, in run
    return self._run_tests(names)
  File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/test/main.py", line 177, in _run_tests
    suites.append(loader.loadTestsFromName(name, None))
  File "/usr/lib/python2.7/unittest/loader.py", line 103, in loadTestsFromName
    return self.loadTestsFromModule(obj)
  File "/usr/lib/python2.7/unittest/loader.py", line 65, in loadTestsFromModule
    tests.append(self.loadTestsFromTestCase(obj))
  File "/usr/lib/python2.7/unittest/loader.py", line 56, in loadTestsFromTestCase
    loaded_suite = self.suiteClass(map(testCaseClass, testCaseNames))
  File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py", line 74, in __init__
    self.test_port = host.port_factory.get('test-win-xp', None)
  File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 110, in get
    module = __import__(module_name, globals(), locals(), [], -1)
  File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 62, in <module>
    DRT_APP_CACHE_DIR = DIR_APP_DIR + 'cache/'
NameError: name 'DIR_APP_DIR' is not defined
Comment 5 Xianzhu Wang 2012-07-10 13:57:04 PDT 
Sorry for the break. The patch (bug 90904) has been in CQ.
Comment 6 Thiago Marcos P. Santos 2012-07-10 13:59:17 PDT 
(In reply to comment #5)
> Sorry for the break. The patch (bug 90904) has been in CQ.

No problem. Thanks for fixing.