http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=1656 Doesn't take border into account properly and makes the iframe too small. http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=1655 Puts scrollbars.
Yup. I'm aware there are a couple minor shrink-wrap issues. Working on security issues with seamless atm. It's probably most helpful to me if you were to attach the reductions to the bug (and that each issue be its own bug). I guess we can trust that Hixie's site will be around a while...
At least the first one looks easy to fix.
Moved the second to bug 90836. This bug is now just about http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=1656: <!DOCTYPE html> ...<style> iframe { border: solid; float: left; } </style> <iframe seamless srcdoc="<style>*{margin:0;padding:0;overflow:hidden}</style><div style='background:yellow'>TEST</div>"></iframe>
It looks like the vertical border is being incorporated correctly, but the horrizontal border isn't. RenderFrame::computeLogicalWidth() just calls up to RenderBox::computeLogicalWidth in the seamless case, being careful to pretend to have the correct replaced/inline/etc flags. I'm not sure what's going wrong in this case.
Since this just popped up on #webkit, I guess I'll take it next.
Hyatt seemed to think this would be easy to fix. It's not obvious to me which line of code is missing here, but this is probably a one-liner. :)
Created attachment 181381 [details] Patch
(In reply to comment #6) > Hyatt seemed to think this would be easy to fix. It's not obvious to me which line of code is missing here, but this is probably a one-liner. :) Two-liner, plus a patch. But you both were right, it was a fairly trivial fix (assuming that I properly converted your instructions into code). Thanks!
Comment on attachment 181381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181381&action=review > LayoutTests/fast/frames/seamless/seamless-border.html:7 > + #hasborder { border: 10px solid black; } Mind adding padding to this test case since your change adds in both border and padding? Or you can do it in a separate patch. I'm not sure we have test coverage that padding on seamless iframes works at all. :)
Comment on attachment 181381 [details] Patch Yes, please do test padding. :) Not required to do so in this patch, but it makes sense to, since it will be easy for you to verify pre-patch if it's broken or not.
You'll be shocked, shocked!, to learn that padding doesn't completely work. This patch fixes padding for the width of the IFrame, but the height isn't picked up. I've added test cases to the patch, and I'll land it with the height failures. I'll tackle that bug in http://wkbug.com/106167
Fantastic!
Created attachment 181428 [details] Patch for landing
Once again, I really appreciate you taking this on Mike.
Comment on attachment 181428 [details] Patch for landing Ugh. Typo.
Created attachment 181429 [details] Patch for landing
Comment on attachment 181429 [details] Patch for landing Clearing flags on attachment: 181429 Committed r138904: <http://trac.webkit.org/changeset/138904>
All reviewed patches have been landed. Closing bug.