Bug 90745 – REGRESSION(r121968): Caused a link error on chromium Win dbg. (Requested by hayato on #webkit).

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/121968 broke the build:
Caused a link error on chromium Win dbg. (Requested by hayato on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 151176 [details]
ROLLOUT of r121968

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Hayato Ito]

Chromium WebKit Win (dbg) build bot started to fail on link from r121968:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder%20%28dbg%29/builds/25935

6>Link:
6>     Creating library ../../../../..\build\Debug\lib\webkit.lib and object ../../../../..\build\Debug\lib\webkit.exp
6>webcore_platform.lib(MemoryUsageSupportChromium.obj) : error LNK2019: unresolved external symbol "public: static void __cdecl SkGlyphCache::VisitAllCaches(bool (__cdecl*)(class SkGlyphCache *,void *),void *)" (?VisitAllCaches@SkGlyphCache@@SAXP6A_NPAV1@PAX@Z1@Z) referenced in function "public: static void __cdecl WebCore::MemoryUsageSupport::memoryUsageByComponents(class WTF::Vector<class WebCore::MemoryUsageSupport::ComponentInfo,0> &)" (?memoryUsageByComponents@MemoryUsageSupport@WebCore@@SAXAAV?$Vector@VComponentInfo@MemoryUsageSupport@WebCore@@$0A@@WTF@@@Z)
6>../../../../..\build\Debug\webkit.dll : fatal error LNK1120: 1 unresolved externals
6>

[WebKit Review Bot]

Comment on attachment 151176 [details]
ROLLOUT of r121968

Rejecting attachment 151176 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13166100

[Hayato Ito]

It seems that the patch created by sheriffbot can not be committed due to http://trac.webkit.org/changeset/122076.

After tkent-san fixed that, let me recreate another rollout patch.

(In reply to comment #3)
> (From update of attachment 151176 [details])
> Rejecting attachment 151176 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://queues.webkit.org/results/13166100

[Hayato Ito]

Created another rollout patch in https://bugs.webkit.org/show_bug.cgi?id=90749.

[Hayato Ito]

*** This bug has been marked as a duplicate of bug 90749 ***