Bug 90626 – CSS 2.1 failure: vertical-align-boxes-001 fails

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Robert Hogan]

.

[Robert Hogan]

Created attachment 150971 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 150971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150971&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:890
> +            if (renderer->style()->verticalAlignLength().isPercent())
> +                verticalPosition -= valueForLength(renderer->style()->verticalAlignLength(), renderer->style()->computedLineHeight(), renderer->view());
> +            else
> +                verticalPosition -= valueForLength(renderer->style()->verticalAlignLength(), renderer->lineHeight(firstLine, lineDirection), renderer->view());

I would have used a local to store the result of either "renderer->style()->computedLineHeight()" or "renderer->lineHeight(firstLine, lineDirection)", means slightly less copy/paste code.

Also, can you please add a comment (link to the spec?) explaining why this is done.  It don't think it will be obvious to future readers of this code.

[Robert Hogan]

Committed r122663: <http://trac.webkit.org/changeset/122663>

[Vsevolod Vlasov]

It is failing on chromium win: https://bugs.webkit.org/show_bug.cgi?id=91372

[Jer Noble]

This looks to have broken the following tests on Lion:

mathml/presentation/mo.xhtml
mathml/presentation/row.xhtml

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r123013%20(1287)/results.html

[Jer Noble]

https://bugs.webkit.org/show_bug.cgi?id=91677