FileSystem related code in Inspector needs some clean up as follows - Clean up layout tests and add test case for error case, - Fix error handling on request, - s/GetFileSystemRootTask/FileSystemRootRequest/g - s/ReadDirectoryTask/DirectoryContentRequest/g - s/ReadFileTask/FileContentRequest/g
Created attachment 150892 [details] Patch
Comment on attachment 150892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150892&action=review Please rebase and fix style nits before landing. > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:195 > + RefPtr<TypeBuilder::FileSystem::Entry> result = RefPtr<TypeBuilder::FileSystem::Entry> result = TypeBuilder::FileSystem::Entry::create() .setUrl(entry->toURL()) .setName("/") .setIsDirectory(true); > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:303 > + RefPtr<TypeBuilder::FileSystem::Entry> entryForFrontend = Ditto. > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:407 > + RefPtr<Metadata> result = Ditto. > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:594 > + *error = "No frame is available for the request"; You can avoid copy-pasting this string several times by extracting assertScriptExecutionContextForOrigin method (like assertDocumentLoader in InspectorPageAgent). > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:664 > + long long startLL = start ? *start : 0; startPosition
Created attachment 151600 [details] Patch
Created attachment 151602 [details] Patch
Created attachment 151608 [details] Patch
Comment on attachment 150892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150892&action=review >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:195 >> + RefPtr<TypeBuilder::FileSystem::Entry> result = > > RefPtr<TypeBuilder::FileSystem::Entry> result = TypeBuilder::FileSystem::Entry::create() > .setUrl(entry->toURL()) > .setName("/") > .setIsDirectory(true); Done >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:303 >> + RefPtr<TypeBuilder::FileSystem::Entry> entryForFrontend = > > Ditto. Done >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:407 >> + RefPtr<Metadata> result = > > Ditto. Done >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:594 >> + *error = "No frame is available for the request"; > > You can avoid copy-pasting this string several times by extracting assertScriptExecutionContextForOrigin method (like assertDocumentLoader in InspectorPageAgent). Sounds nice. Done >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:664 >> + long long startLL = start ? *start : 0; > > startPosition Done
Comment on attachment 151608 [details] Patch Rejecting attachment 151608 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11988 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 11988. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13200229
Committed r122313: <http://trac.webkit.org/changeset/122313>