Bug 90439 - Web Inspector: Add text file support for FileSystemAgent::requestFileContent
Summary: Web Inspector: Add text file support for FileSystemAgent::requestFileContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on:
Blocks: 68203 90529 90592
  Show dependency tree / graph
 
Reported: 2012-07-03 02:20 PDT by Taiju Tsuiki
Modified: 2012-07-09 03:52 PDT (History)
11 users (show)

See Also:

Attachments
Patch (20.92 KB, patch)
2012-07-03 02:22 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (21.26 KB, patch)
2012-07-04 01:06 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (24.28 KB, patch)
2012-07-09 00:29 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (24.71 KB, patch)
2012-07-09 00:49 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (24.71 KB, patch)
2012-07-09 01:10 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (24.42 KB, patch)
2012-07-09 01:22 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-07-03 02:20:28 PDT 
For FileSystem support of Inspector, text file support is needed.
That is, I'd like to add:
 - Charset detection
 - Text decoding on load
 - Charset override
to backend InspectorFileSystemAgent.
Comment 1 Taiju Tsuiki 2012-07-03 02:22:52 PDT 
Created attachment 150563 [details]
Patch
Comment 2 Taiju Tsuiki 2012-07-04 01:06:35 PDT 
Created attachment 150735 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-07-05 14:06:47 PDT 
Comment on attachment 150735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150735&action=review

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:111
> +    return mimeType.startsWith("text/") || mimeType.endsWith("+xml") || mimeType.endsWith("/javascript");

See NetworkResourcesData (http://code.google.com/p/chromium/source/search?q=file%3Ainspector+%22.mimetype+%3D+%22&origq=file%3Ainspector+%22.mimetype+%3D+%22&btnG=Search+Trunk) for a more precise text and charset detection (at least for xml mime-types).
Can we reuse it?
Comment 4 Taiju Tsuiki 2012-07-09 00:29:10 PDT 
Created attachment 151197 [details]
Patch
Comment 5 Taiju Tsuiki 2012-07-09 00:49:31 PDT 
Created attachment 151203 [details]
Patch
Comment 6 Taiju Tsuiki 2012-07-09 01:10:33 PDT 
Created attachment 151207 [details]
Patch
Comment 7 Taiju Tsuiki 2012-07-09 01:22:12 PDT 
Created attachment 151209 [details]
Patch
Comment 8 WebKit Review Bot 2012-07-09 03:52:28 PDT 
Comment on attachment 151209 [details]
Patch

Clearing flags on attachment: 151209

Committed r122101: <http://trac.webkit.org/changeset/122101>
Comment 9 WebKit Review Bot 2012-07-09 03:52:33 PDT 
All reviewed patches have been landed.  Closing bug.