Bug 90548 - [WK2][EFL] Add API to Ewk_View to set / get zoom level
Summary: [WK2][EFL] Add API to Ewk_View to set / get zoom level
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency treegraph
 
Reported: 2012-07-04 06:41 PDT by Chris Dumez
Modified: 2012-07-05 01:04 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.87 KB, patch)
2012-07-04 06:43 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-04 06:41:34 PDT
We should add methods to the Ewk_View to set and get the zoom levels for both the page and the text.
Comment 1 Chris Dumez 2012-07-04 06:43:54 PDT
Created attachment 150784 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-07-04 19:07:20 PDT
Comment on attachment 150784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150784&action=review

> Source/WebKit2/ChangeLog:10
> +
> +        Add methods to Ewk_View and retrieve and set the
> +        zoom levels for both the page and the text.
> +

zoom level is really legacy, and for accessibility I guess some min font sizes should be used instead. Are you sure you want to add this?
Comment 3 Chris Dumez 2012-07-04 22:32:25 PDT
(In reply to comment #2)
> (From update of attachment 150784 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150784&action=review
> 
> > Source/WebKit2/ChangeLog:10
> > +
> > +        Add methods to Ewk_View and retrieve and set the
> > +        zoom levels for both the page and the text.
> > +
> 
> zoom level is really legacy, and for accessibility I guess some min font sizes should be used instead. Are you sure you want to add this?

I did not know those were legacy. We had those methods in WK1 and use them at least in EWKLauncher so I added them back so not to loose functionality.

The WK2 GTK port has those methods as well.
I checked the Qt port and only the "page" zoom is marked as legacy, not the "text" one.

I know EWSLauncher uses the zoom feature and I was planning to do the same for EFL MiniBrowser after this patch landed.
Comment 4 Kenneth Rohde Christiansen 2012-07-04 23:43:32 PDT
The reason that I am mentioning this is that there is an ongoing consolidation of mobile and desktop browser behavior and lots of pieces to fall into their right spots. This relates to viewport interaction, layout sizes etc. And in this light the zoom is like a legacy accesibility feature which doesn't really belong on mobile devices and it is hard to find where it really fits. I actually believe it is a very seldom used feature today, because it can totally break layout and it does more so today that earlier due to pages using more detailed layout and due to web apps expecting specific sizes. For Qt we are trying to not open a can of worms and only add support like this when we know there is a proper understood use-case and when we know how it all fits together.
Comment 5 Chris Dumez 2012-07-04 23:51:32 PDT
gyuyoung, ryuan, do you have use for those APIs? Dominik, any opinion?
If we consider other targets than mobile (in particular TV and IVI), does it make more sense?

I don't mind dropping the patch if we don't have any use for it on any target. I would just like to make sure everyone thinks this way.
Comment 6 Gyuyoung Kim 2012-07-05 00:16:16 PDT
Though I'm not sure now, in my opinion, EFL port may be used by TV, tablet and other electronics in future. I was told there is a project to port WebKit EFL to other devices now.

In addition, as you may know, Tizen is using WebKit EFL as web engine.
 - https://www.tizen.org/about

Tizen goal is to be ported to many devices. So, in my humble opinion, it is good  to add this APIs for EFL port.
Comment 7 Kenneth Rohde Christiansen 2012-07-05 00:41:53 PDT
(In reply to comment #6)
> Though I'm not sure now, in my opinion, EFL port may be used by TV, tablet and other electronics in future. I was told there is a project to port WebKit EFL to other devices now.

This it should be solved differently depending on target DPI as well as distance to the screen. CSS is specified as 96dpi, but mobile content is laid out as the screen is using 160dpi (if different it is scaled up/down with the device pixel ratio), as that fits with 96dpi given the most common viewing distance.

Something similar should be done for TV's. That is the right way to solve it.
Comment 8 Chris Dumez 2012-07-05 01:04:15 PDT
Marking as WONTFIX for later reference.
I'll implement device pixel ratio is a separate bug.
Comment 9 Gyuyoung Kim 2012-07-05 01:04:49 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > Though I'm not sure now, in my opinion, EFL port may be used by TV, tablet and other electronics in future. I was told there is a project to port WebKit EFL to other devices now.
> 
> This it should be solved differently depending on target DPI as well as distance to the screen. CSS is specified as 96dpi, but mobile content is laid out as the screen is using 160dpi (if different it is scaled up/down with the device pixel ratio), as that fits with 96dpi given the most common viewing distance.
> 
> Something similar should be done for TV's. That is the right way to solve it.

I see what is your point on #webkit-efl irc. Ok, I agree with your advice. Thanks.