Bug 90457 - [WK2][EFL] Ewk_View should report the load progress
Summary: [WK2][EFL] Ewk_View should report the load progress
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency tree / graph
 
Reported: 2012-07-03 06:33 PDT by Chris Dumez
Modified: 2012-07-03 23:35 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.23 KB, patch)
2012-07-03 06:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.26 KB, patch)
2012-07-03 11:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.26 KB, patch)
2012-07-03 22:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-03 06:33:27 PDT 
Ewk_View should report the load progress and we should use this information in the MiniBrowser to display it in the title bar.
Comment 1 Chris Dumez 2012-07-03 06:44:17 PDT 
Created attachment 150598 [details]
Patch
Comment 2 Chris Dumez 2012-07-03 11:19:43 PDT 
Created attachment 150648 [details]
Patch

Rebase on master
Comment 3 Kenneth Rohde Christiansen 2012-07-03 18:54:30 PDT 
Comment on attachment 150648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150648&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:575
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1);
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, -1);

Wouldnt 0 be a better value? It is not loaded? instead of invalid... seems like more code to handle for users of this api

> Tools/MiniBrowser/efl/main.c:95
> +    char label[4096];

Wouldnt it be better to use a string builder or so instead? then get the string from that.
Comment 4 Chris Dumez 2012-07-03 22:55:50 PDT 
Created attachment 150715 [details]
Patch

Take Kenneth feedback into consideration.
Comment 5 WebKit Review Bot 2012-07-03 23:35:07 PDT 
Comment on attachment 150715 [details]
Patch

Clearing flags on attachment: 150715

Committed r121830: <http://trac.webkit.org/changeset/121830>
Comment 6 WebKit Review Bot 2012-07-03 23:35:12 PDT 
All reviewed patches have been landed.  Closing bug.