Bug 90432 - Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker
Summary: Remove inline keywords from functions which can not be inlined in ComposedSha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 82702
  Show dependency tree / graph
 
Reported: 2012-07-02 22:39 PDT by Hayato Ito
Modified: 2012-07-04 18:25 PDT (History)
6 users (show)

See Also:

Attachments
remove inline. (2.08 KB, patch)
2012-07-02 22:44 PDT, Hayato Ito 		no flags Details | Formatted Diff | Diff
Add a FIXME comment (2.15 KB, patch)
2012-07-04 15:57 PDT, Hayato Ito 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-07-02 22:39:17 PDT 
Some functions can not be inlined as is because they are recursive ones and some of them call mutually.
Comment 1 Hayato Ito 2012-07-02 22:44:37 PDT 
Created attachment 150536 [details]
remove inline.
Comment 2 Hayato Ito 2012-07-02 22:46:32 PDT 
Until https://bugs.webkit.org/show_bug.cgi?id=90415 is implemented, it might be better to remove inline keywords since the functions are not inlined actually.
Comment 3 Hajime Morrita 2012-07-04 02:24:34 PDT 
Comment on attachment 150536 [details]
remove inline.

No, this is actually intended to be inlined.
These functions are private, and called only from this file, thus can be inlined.
And this inlining impacts NodRenderingContext speed.
Comment 4 Hayato Ito 2012-07-04 02:40:34 PDT 
We can not inline these. These are mutually recursive functions. See https://bugs.webkit.org/show_bug.cgi?id=90432#c0 and comment #2.
objdump told me that these are not inlined on chromium linux port actually.

(In reply to comment #3)
> (From update of attachment 150536 [details])
> No, this is actually intended to be inlined.
> These functions are private, and called only from this file, thus can be inlined.
> And this inlining impacts NodRenderingContext speed.
Comment 5 Hayato Ito 2012-07-04 15:57:16 PDT 
Created attachment 150850 [details]
Add a FIXME comment
Comment 6 Hajime Morrita 2012-07-04 17:23:44 PDT 
Comment on attachment 150850 [details]
Add a FIXME comment

Ah got it.
Comment 7 WebKit Review Bot 2012-07-04 18:25:27 PDT 
Comment on attachment 150850 [details]
Add a FIXME comment

Clearing flags on attachment: 150850

Committed r121875: <http://trac.webkit.org/changeset/121875>
Comment 8 WebKit Review Bot 2012-07-04 18:25:32 PDT 
All reviewed patches have been landed.  Closing bug.