RESOLVED FIXED 90432
Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker 
https://bugs.webkit.org/show_bug.cgi?id=90432
Summary Remove inline keywords from functions which can not be inlined in ComposedSha...
Hayato Ito
Reported 2012-07-02 22:39:17 PDT
Some functions can not be inlined as is because they are recursive ones and some of them call mutually.
Attachments
remove inline. (2.08 KB, patch)
2012-07-02 22:44 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Add a FIXME comment (2.15 KB, patch)
2012-07-04 15:57 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-07-02 22:44:37 PDT
Created attachment 150536 [details] remove inline.
Hayato Ito
Comment 2 2012-07-02 22:46:32 PDT
Until https://bugs.webkit.org/show_bug.cgi?id=90415 is implemented, it might be better to remove inline keywords since the functions are not inlined actually.
Hajime Morrita
Comment 3 2012-07-04 02:24:34 PDT
Comment on attachment 150536 [details] remove inline. No, this is actually intended to be inlined. These functions are private, and called only from this file, thus can be inlined. And this inlining impacts NodRenderingContext speed.
Hayato Ito
Comment 4 2012-07-04 02:40:34 PDT
We can not inline these. These are mutually recursive functions. See https://bugs.webkit.org/show_bug.cgi?id=90432#c0 and comment #2. objdump told me that these are not inlined on chromium linux port actually. (In reply to comment #3) > (From update of attachment 150536 [details]) > No, this is actually intended to be inlined. > These functions are private, and called only from this file, thus can be inlined. > And this inlining impacts NodRenderingContext speed.
Hayato Ito
Comment 5 2012-07-04 15:57:16 PDT
Created attachment 150850 [details] Add a FIXME comment
Hajime Morrita
Comment 6 2012-07-04 17:23:44 PDT
Comment on attachment 150850 [details] Add a FIXME comment Ah got it.
WebKit Review Bot
Comment 7 2012-07-04 18:25:27 PDT
Comment on attachment 150850 [details] Add a FIXME comment Clearing flags on attachment: 150850 Committed r121875: <http://trac.webkit.org/changeset/121875>
WebKit Review Bot
Comment 8 2012-07-04 18:25:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.