RESOLVED FIXED 90372
[Qt][WK2] New API tests introduced in r121620 fail 
https://bugs.webkit.org/show_bug.cgi?id=90372
Summary [Qt][WK2] New API tests introduced in r121620 fail
Csaba Osztrogonác
Reported 2012-07-02 04:53:59 PDT
FAIL! : tst_qrawwebview::noBackground1() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)] FAIL! : tst_qrawwebview::noBackground2() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)] FAIL! : tst_qrawwebview::noBackground3() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)] Sholdn't we mark them as expected fails? If there are many failing tests on the bot, it's so hard to catch new regressions.
Attachments
Patch (2.44 KB, patch)
2012-07-02 09:53 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-07-02 05:48:37 PDT
Yes, let's mark as expected fails for now and we'll fix those.
Noam Rosenthal
Comment 2 2012-07-02 09:53:02 PDT
Created attachment 150437 [details] Patch
WebKit Review Bot
Comment 3 2012-07-02 12:12:45 PDT
Comment on attachment 150437 [details] Patch Clearing flags on attachment: 150437 Committed r121698: <http://trac.webkit.org/changeset/121698>
WebKit Review Bot
Comment 4 2012-07-02 12:12:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.