Bug 90372 - [Qt][WK2] New API tests introduced in r121620 fail
Summary: [Qt][WK2] New API tests introduced in r121620 fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 70236 84532
  Show dependency tree / graph
 
Reported: 2012-07-02 04:53 PDT by Csaba Osztrogonác
Modified: 2012-07-02 12:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.44 KB, patch)
2012-07-02 09:53 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-07-02 04:53:59 PDT 
FAIL!  : tst_qrawwebview::noBackground1() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)]
FAIL!  : tst_qrawwebview::noBackground2() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)]
FAIL!  : tst_qrawwebview::noBackground3() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)]

Sholdn't we mark them as expected fails? If there are many 
failing tests on the bot, it's so hard to catch new regressions.
Comment 1 Noam Rosenthal 2012-07-02 05:48:37 PDT 
Yes, let's mark as expected fails for now and we'll fix those.
Comment 2 Noam Rosenthal 2012-07-02 09:53:02 PDT 
Created attachment 150437 [details]
Patch
Comment 3 WebKit Review Bot 2012-07-02 12:12:45 PDT 
Comment on attachment 150437 [details]
Patch

Clearing flags on attachment: 150437

Committed r121698: <http://trac.webkit.org/changeset/121698>
Comment 4 WebKit Review Bot 2012-07-02 12:12:50 PDT 
All reviewed patches have been landed.  Closing bug.