Bug 90212 – [chromium] Reset the device scale factor to 1 before each test is run

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Terry Anderson]

Tests using testRunner.setBackingScaleFactor change the device scale factor but do not reset this back to 1 at the end of the test. This leads to a large number of flaky tests as noted in https://bugs.webkit.org/show_bug.cgi?id=83635

[Terry Anderson]

Created attachment 150024 [details]
Patch

[Adam Barth]

Comment on attachment 150024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review

> Tools/ChangeLog:6
> +        Reviewed by Adam Barth.

You should leave this line with the NOBODY (OOPS)! string.  The tools will fill it in based on who actually reviews the patch.

[Stephen White]

Comment on attachment 150024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:653
> +        m_shell->webView()->setDeviceScaleFactor(1.0);

Nit:  "Unless required in order to force floating point math, do not append .0, .f and .0f to floating point literals."

[Adam Barth]

Comment on attachment 150024 [details]
Patch

Thanks.

[Terry Anderson]

Created attachment 150031 [details]
Patch

[Adam Barth]

Comment on attachment 150031 [details]
Patch

Clearing flags on attachment: 150031

Committed r121489: <http://trac.webkit.org/changeset/121489>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.