Unskip these high dpi tests and add baselines for chromium.
Created attachment 153617 [details] Patch
I'm surprised you got consistent text rendering across the different Chromium ports. I would expect each one to be slightly different. I guess the bots will tell us when we land this patch. Please let the gardener know when you land this patch so that he/she can be prepared.
(In reply to comment #2) > I'm surprised you got consistent text rendering across the different Chromium ports. I would expect each one to be slightly different. I guess the bots will tell us when we land this patch. Please let the gardener know when you land this patch so that he/she can be prepared. Actually, this was an error on my part... the baselines in my CL should have been in chromium-linux/ instead of chromium/.
Created attachment 153626 [details] Patch
Comment on attachment 153626 [details] Patch Rejecting attachment 153626 [details] from commit-queue. New failing tests: fast/hidpi/broken-image-icon-hidpi.html fast/hidpi/image-set-out-of-order.html fast/hidpi/image-set-as-background.html fast/hidpi/image-set-in-content-dynamic.html fast/hidpi/device-scale-factor-paint.html fast/hidpi/resize-corner-hidpi.html fast/hidpi/broken-image-with-size-hidpi.html fast/hidpi/image-set-border-image-comparison.html fast/hidpi/video-controls-in-hidpi.html fast/hidpi/image-set-border-image-simple.html fast/hidpi/image-set-background-repeat-without-size.html fast/hidpi/image-set-simple.html fast/hidpi/image-set-background-dynamic.html fast/hidpi/image-set-without-specified-width.html fast/hidpi/focus-rings.html fast/hidpi/clip-text-in-hidpi.html fast/hidpi/image-set-border-image-dynamic.html fast/hidpi/image-set-background-repeat.html Full output: http://queues.webkit.org/results/13315383
Created attachment 153634 [details] Archive of layout-test-results from gce-cq-03 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: gce-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
These are failing with IMAGE+TEXT, which seems like it should be included in FAIL...
I'm just going to land this. If this causes trouble, I'll fix it in the main tree.
Comment on attachment 153626 [details] Patch Attachment 153626 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13308466 New failing tests: fast/hidpi/broken-image-icon-hidpi.html fast/hidpi/image-set-out-of-order.html fast/hidpi/image-set-as-background.html fast/hidpi/image-set-in-content-dynamic.html fast/hidpi/device-scale-factor-paint.html fast/hidpi/resize-corner-hidpi.html fast/hidpi/broken-image-with-size-hidpi.html fast/hidpi/image-set-border-image-comparison.html fast/hidpi/video-controls-in-hidpi.html fast/hidpi/image-set-border-image-simple.html fast/hidpi/image-set-background-repeat-without-size.html fast/hidpi/image-set-simple.html fast/hidpi/image-set-background-dynamic.html fast/hidpi/image-set-without-specified-width.html fast/hidpi/focus-rings.html fast/hidpi/clip-text-in-hidpi.html fast/hidpi/image-set-border-image-dynamic.html fast/hidpi/image-set-background-repeat.html
Created attachment 153637 [details] Archive of layout-test-results from gce-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 153886 [details] Patch
Comment on attachment 153886 [details] Patch Attachment 153886 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13331162 New failing tests: fast/hidpi/image-set-background-repeat-without-size.html fast/hidpi/image-set-background-repeat.html
Created attachment 153904 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
> fast/hidpi/image-set-background-repeat-without-size.html > fast/hidpi/image-set-background-repeat.html Perhaps these still timeout?
(In reply to comment #14) > > fast/hidpi/image-set-background-repeat-without-size.html > > fast/hidpi/image-set-background-repeat.html > > Perhaps these still timeout? It is actually because a patch was landed in the last two days that would make these baselines look different, so the results in the attached zip were out of date. I'm updating these now.
Created attachment 154063 [details] Patch
Comment on attachment 154063 [details] Patch Clearing flags on attachment: 154063 Committed r123490: <http://trac.webkit.org/changeset/123490>
All reviewed patches have been landed. Closing bug.