Bug 90190 - [chromium] Unskip tests in fast/hidpi
Summary: [chromium] Unskip tests in fast/hidpi
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Terry Anderson
URL:
Keywords:
Depends on: 83635
Blocks: 88121 90192
  Show dependency treegraph
 
Reported: 2012-06-28 11:10 PDT by Terry Anderson
Modified: 2012-07-24 10:17 PDT (History)
8 users (show)

See Also:


Attachments
Patch (192.14 KB, patch)
2012-07-20 16:23 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2012-07-20 17:03 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-03 (1.32 MB, application/zip)
2012-07-20 18:21 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from gce-cr-linux-02 (1.31 MB, application/zip)
2012-07-20 18:35 PDT, WebKit Review Bot
no flags Details
Patch (267.08 KB, patch)
2012-07-23 15:52 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (412.68 KB, application/zip)
2012-07-23 17:03 PDT, WebKit Review Bot
no flags Details
Patch (279.39 KB, patch)
2012-07-24 08:00 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Anderson 2012-06-28 11:10:47 PDT
Unskip these high dpi tests and add baselines for chromium.
Comment 1 Terry Anderson 2012-07-20 16:23:24 PDT
Created attachment 153617 [details]
Patch
Comment 2 Adam Barth 2012-07-20 16:31:55 PDT
I'm surprised you got consistent text rendering across the different Chromium ports.  I would expect each one to be slightly different.  I guess the bots will tell us when we land this patch.  Please let the gardener know when you land this patch so that he/she can be prepared.
Comment 3 Terry Anderson 2012-07-20 16:38:21 PDT
(In reply to comment #2)
> I'm surprised you got consistent text rendering across the different Chromium ports.  I would expect each one to be slightly different.  I guess the bots will tell us when we land this patch.  Please let the gardener know when you land this patch so that he/she can be prepared.

Actually, this was an error on my part... the baselines in my CL should have been in chromium-linux/ instead of chromium/.
Comment 4 Terry Anderson 2012-07-20 17:03:28 PDT
Created attachment 153626 [details]
Patch
Comment 5 WebKit Review Bot 2012-07-20 18:21:39 PDT
Comment on attachment 153626 [details]
Patch

Rejecting attachment 153626 [details] from commit-queue.

New failing tests:
fast/hidpi/broken-image-icon-hidpi.html
fast/hidpi/image-set-out-of-order.html
fast/hidpi/image-set-as-background.html
fast/hidpi/image-set-in-content-dynamic.html
fast/hidpi/device-scale-factor-paint.html
fast/hidpi/resize-corner-hidpi.html
fast/hidpi/broken-image-with-size-hidpi.html
fast/hidpi/image-set-border-image-comparison.html
fast/hidpi/video-controls-in-hidpi.html
fast/hidpi/image-set-border-image-simple.html
fast/hidpi/image-set-background-repeat-without-size.html
fast/hidpi/image-set-simple.html
fast/hidpi/image-set-background-dynamic.html
fast/hidpi/image-set-without-specified-width.html
fast/hidpi/focus-rings.html
fast/hidpi/clip-text-in-hidpi.html
fast/hidpi/image-set-border-image-dynamic.html
fast/hidpi/image-set-background-repeat.html
Full output: http://queues.webkit.org/results/13315383
Comment 6 WebKit Review Bot 2012-07-20 18:21:43 PDT
Created attachment 153634 [details]
Archive of layout-test-results from gce-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 Adam Barth 2012-07-20 18:30:05 PDT
These are failing with IMAGE+TEXT, which seems like it should be included in FAIL...
Comment 8 Adam Barth 2012-07-20 18:31:58 PDT
I'm just going to land this.  If this causes trouble, I'll fix it in the main tree.
Comment 9 WebKit Review Bot 2012-07-20 18:35:51 PDT
Comment on attachment 153626 [details]
Patch

Attachment 153626 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13308466

New failing tests:
fast/hidpi/broken-image-icon-hidpi.html
fast/hidpi/image-set-out-of-order.html
fast/hidpi/image-set-as-background.html
fast/hidpi/image-set-in-content-dynamic.html
fast/hidpi/device-scale-factor-paint.html
fast/hidpi/resize-corner-hidpi.html
fast/hidpi/broken-image-with-size-hidpi.html
fast/hidpi/image-set-border-image-comparison.html
fast/hidpi/video-controls-in-hidpi.html
fast/hidpi/image-set-border-image-simple.html
fast/hidpi/image-set-background-repeat-without-size.html
fast/hidpi/image-set-simple.html
fast/hidpi/image-set-background-dynamic.html
fast/hidpi/image-set-without-specified-width.html
fast/hidpi/focus-rings.html
fast/hidpi/clip-text-in-hidpi.html
fast/hidpi/image-set-border-image-dynamic.html
fast/hidpi/image-set-background-repeat.html
Comment 10 WebKit Review Bot 2012-07-20 18:35:56 PDT
Created attachment 153637 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 Terry Anderson 2012-07-23 15:52:48 PDT
Created attachment 153886 [details]
Patch
Comment 12 WebKit Review Bot 2012-07-23 17:03:54 PDT
Comment on attachment 153886 [details]
Patch

Attachment 153886 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13331162

New failing tests:
fast/hidpi/image-set-background-repeat-without-size.html
fast/hidpi/image-set-background-repeat.html
Comment 13 WebKit Review Bot 2012-07-23 17:03:58 PDT
Created attachment 153904 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 14 Adam Barth 2012-07-23 17:25:04 PDT
> fast/hidpi/image-set-background-repeat-without-size.html
> fast/hidpi/image-set-background-repeat.html

Perhaps these still timeout?
Comment 15 Terry Anderson 2012-07-24 07:53:31 PDT
(In reply to comment #14)
> > fast/hidpi/image-set-background-repeat-without-size.html
> > fast/hidpi/image-set-background-repeat.html
> 
> Perhaps these still timeout?

It is actually because a patch was landed in the last two days that would make these baselines look different, so the results in the attached zip were out of date. I'm updating these now.
Comment 16 Terry Anderson 2012-07-24 08:00:06 PDT
Created attachment 154063 [details]
Patch
Comment 17 WebKit Review Bot 2012-07-24 10:17:05 PDT
Comment on attachment 154063 [details]
Patch

Clearing flags on attachment: 154063

Committed r123490: <http://trac.webkit.org/changeset/123490>
Comment 18 WebKit Review Bot 2012-07-24 10:17:10 PDT
All reviewed patches have been landed.  Closing bug.