It made a Qt-WK2 API test fail:
FAIL! : qmltests::WebViewColorChooser::test_accept() Compared values are not the same
Actual (): 1
Expected (): 2
Could you check it, please?
You can easily reproduce this fail with and without xvfb:
- ./Tools/Scripts/run-qtwebkit-tests --output-file=qt-unit-tests.html --do-not-open-results --timeout=120 WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/
- xvfb-run -a --server-args="-screen 0 1024x768x24" $@ ...
This test always fail for me, execution mode doesn't matter at all.
Created attachment 149343 [details]
I could not reproduce the error on my desktop, but anyway, some assumptions made by the test case about the arrival of titleChanged events are wrong. Also, the SignalSpy counter was potentially leaking to the next test case. This would all depends on how fast the machine delivery these asynchronous signals.
I do believe now that the test case is fixed (added signal synchronization and test cleanup). I tried here both with --input-type-color and without and it works.
Would be really nice if you could try the patch at your computer.
Thanks a lot!
The test passes with your patch. (But unfortunately I can't
review it, because I don't know anything about this stuff.)
Created attachment 149781 [details]
(In reply to comment #5)
> Created an attachment (id=149781) [details]
Addressed comments by Simon on the #irc. Basically got rid of the magic numbers at "function init()" from the previous patch.
Comment on attachment 149781 [details]
Clearing flags on attachment: 149781
Committed r121370: <http://trac.webkit.org/changeset/121370>
All reviewed patches have been landed. Closing bug.