Bug 89830 – [EFL] Hyphenation is not supported

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

The EFL port does not support hyphenation causing several tests to not behave as expected. For e.g.
  fast/text/hyphenate-first-word.html
  fast/text/hyphenate-locale.html
  fast/text/hyphen-min-preferred-width.html

Some of those tests are unskipped because they have EFL-specific results without hyphenation. The Mac port supports hyphenation and their results look quite different.
The GTK port does not support hyphenation either (Bug 44478).

[Ryuan Choi]

Created attachment 255388 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 255388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255388&action=review

> Source/WebCore/PlatformEfl.cmake:544
> +        add_definitions(-DTEST_HYPHENATAION_PATH=\"${CMAKE_SOURCE_DIR}/WebKitBuild/DependenciesEFL/Root/webkitgtk-test-dicts\")

We need to add webkitgtk-test-dicts to jhbuild list.

[Gyuyoung Kim]

Comment on attachment 255388 [details]
Patch

ok, EFL ews didn't download *webkitgtk-test-dicts* using jhbuild. Let me run it after landing this patch. I believe that GTK folk don't mind to move HyphenationLibHyphen.cpp to common place.

[Ryuan Choi]

Comment on attachment 255388 [details]
Patch

Clearing flags on attachment: 255388

Committed r185862: <http://trac.webkit.org/changeset/185862>

[Ryuan Choi]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #4)
> Comment on attachment 255388 [details]
> Patch
> 
> Clearing flags on attachment: 255388
> 
> Committed r185862: <http://trac.webkit.org/changeset/185862>

It broke the EFL build as the EWS noticed:

-- Could NOT find HYPHEN (missing:  HYPHEN_INCLUDE_DIR HYPHEN_LIBRARIES) 
CMake Error at Source/cmake/OptionsEfl.cmake:296 (message):
  libhyphen is needed for USE_LIBHYPHEN.
Call Stack (most recent call first):
  CMakeLists.txt:163 (include)

Why did you land it before installing this new dependency on the EWS
and the buildbot? Additionally you should have added libhyphen-dev
to Tools/efl/install-dependencies in this patch.

[Csaba Osztrogonác]

I added libhyphen-dev to Tools/efl/install-dependencies in bug146230
and will install this library on the ARM bots and the perf bot too.

[Ryuan Choi]

(In reply to comment #6)
> (In reply to comment #4)
> > Comment on attachment 255388 [details]
> > Patch
> > 
> > Clearing flags on attachment: 255388
> > 
> > Committed r185862: <http://trac.webkit.org/changeset/185862>
> 
> It broke the EFL build as the EWS noticed:
> 
> -- Could NOT find HYPHEN (missing:  HYPHEN_INCLUDE_DIR HYPHEN_LIBRARIES) 
> CMake Error at Source/cmake/OptionsEfl.cmake:296 (message):
>   libhyphen is needed for USE_LIBHYPHEN.
> Call Stack (most recent call first):
>   CMakeLists.txt:163 (include)
> 
> Why did you land it before installing this new dependency on the EWS
> and the buildbot? Additionally you should have added libhyphen-dev
> to Tools/efl/install-dependencies in this patch.

Sorry, I fogot it.
I just asked to gyuyoung to install libhyphen-dev.

I will consider it more carefully next time.

(In reply to comment #7)
> I added libhyphen-dev to Tools/efl/install-dependencies in bug146230
> and will install this library on the ARM bots and the perf bot too.

Thanks.