Bug 8974 - REGRESSION: notes cannot be created at google/notebook
Summary: REGRESSION: notes cannot be created at google/notebook
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Evangelism (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://www.google.com/notebook/fullpage
Keywords: GoogleBug, HasReduction, InRadar, Regression
: 17416 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-05-18 06:23 PDT by tim bates
Modified: 2008-06-05 22:36 PDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tim bates 2006-05-18 06:23:09 PDT
This is a very vague bug, i know. but  google/notebooks doesn't function properly.
you can click the create note button once, and the word processor UI builds, but you can't enter text, and the create button is then broken.

write once once debug everywhere i know, but they will support firefox, which means mac users will move there if safari is "broken".
Comment 1 Joost de Valk (AlthA) 2006-07-12 10:20:41 PDT
Adding GoogleBug keyword in one big change.
Comment 2 Sam Weinig 2006-07-12 12:34:05 PDT
Confirming that you cannot edit newly created notes in ToT.  Interestingly, it works somewhat in shipping Safari (as of 10.4.7) although not correctly, but a notable regression is evident. 
Comment 3 David Kilzer (:ddkilzer) 2006-07-12 13:40:52 PDT
Adding NeedsRadar keyword, although I'm not sure whether this one would qualify since the functionality is only partially working in shipping Safari.
Comment 4 Alice Liu 2006-07-14 15:54:17 PDT
<rdar://problem/4631597>
Comment 5 Maciej Stachowiak 2006-07-18 21:59:29 PDT
The reason this is failing is that Google Notebook now thinks TOT Safari is Mozilla, so it uses designMode instead of contentEditable, which fails grievously. The reason is they use this check for Mozilla:

    return this.Run(document.implementation && document.implementation.createDocument && !document.contains) != false;

and this for Safari:

    return this.Run(document.implementation && document.implementation.createDocument && document.contains) != false;

Safari used to have document.contains on the Document node as a weird Safari-specific quirk (for some reason contains was implemented on Node instead of Element) but we have now fixed this. I think the right action is to ask Google to fix this on their end.
Comment 6 David Kilzer (:ddkilzer) 2007-02-07 02:53:34 PST
Perhaps Bob knows who to talk to at Google to get this fixed.  This resource describes the preferred way to detect WebKit:

http://trac.webkit.org/projects/webkit/wiki/DetectingWebKit

Reduction found in Comment #5.

Comment 7 Robert Blaut 2008-01-31 22:37:20 PST
I sent bug report to Google Notebook team a while ago and got answer:

Date: Wed, 14 Nov 2007 19:04:13 -0000
From: notebook-support@google.com
Subject: Re: [#214346367] Notes cannot be created with Safari browser

Thank you for taking the time to report this problem. We've forwarded your note to the Notebook engineering team for investigation. We appreciate your assistance as we work to improve Google Notebook.

Regards,
The Google Team

Notebook still doesn't work :(


Comment 8 mitz 2008-02-17 17:48:30 PST
*** Bug 17416 has been marked as a duplicate of this bug. ***
Comment 9 Robert Blaut 2008-06-05 22:36:16 PDT
After checking Google Notebook today, I can say that the reported issue is no longer visible. Additionally, it seems that Safari/Webkit is currently fully supported by Google Notebook  (except an extension ;) [http://www.google.com/googlenotebook/faq.html#extensionsupport]

I close the bug as FIXED. Please close the Radar bug as well.