Bug 89587 - IndexedDB: Remove redundant IDBObjectStore.delete() overloads
Summary: IndexedDB: Remove redundant IDBObjectStore.delete() overloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 11:33 PDT by Joshua Bell
Modified: 2012-06-20 17:32 PDT (History)
8 users (show)

See Also:


Attachments
Patch (30.42 KB, patch)
2012-06-20 11:55 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch for landing (30.53 KB, patch)
2012-06-20 14:28 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-06-20 11:33:09 PDT
IndexedDB: Remove redundant IDBObjectStore.delete() overloads
Comment 1 Joshua Bell 2012-06-20 11:55:52 PDT
Created attachment 148617 [details]
Patch
Comment 2 Joshua Bell 2012-06-20 11:56:55 PDT
alecflett@ - can you take an initial look?

Chromium WebKit API reviewers - please, sir, may I delete some code?
Comment 3 WebKit Review Bot 2012-06-20 11:57:36 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Alec Flett 2012-06-20 13:37:44 PDT
LGTM - you're gonna collide with https://bugs.webkit.org/show_bug.cgi?id=86123 (or I'll collide with you, either way :))
Comment 5 WebKit Review Bot 2012-06-20 14:20:41 PDT
Comment on attachment 148617 [details]
Patch

Rejecting attachment 148617 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 37 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 37.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13008329
Comment 6 Joshua Bell 2012-06-20 14:28:07 PDT
Created attachment 148655 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-06-20 17:32:00 PDT
Comment on attachment 148655 [details]
Patch for landing

Clearing flags on attachment: 148655

Committed r120888: <http://trac.webkit.org/changeset/120888>
Comment 8 WebKit Review Bot 2012-06-20 17:32:05 PDT
All reviewed patches have been landed.  Closing bug.